Skip to content

Tests Fail Depending on tomlkit Version #628

Open
@adam-grant-hendry

Description

@adam-grant-hendry

Description

PR #626 changed

tests/commands/test_bump_command.py
tests/commands/test_init_command.py
tests/test_conf.py

to accomodate changes to tomlkit from 0.11.5 to 0.11.6. However, the pyproject.toml still has the version set as

tomlkit = ">=0.5.3,<1.0.0"

Hence, tests fail for tomlkit<=0.11.5.

Steps to reproduce

Run pytest on commitizen repo with tomlkit<=0.11.5.

Current behavior

The following 6 tests fail:

pytest_report.zip

when tomlkit is <= 0.11.5, but pass when tomlkit >= 0.11.6.

Desired behavior

Either of the following, depending on what should be supported:

  1. Update pyproject.toml to specify

    tomlkit = ">=0.11.6,<1.0.0"
    

or

  1. Add test cases for tomlkit <=0.11.5 separate from test cases for tomlkit > 0.11.5.

Screenshots

No response

Environment

  • commitizen version: 2.37.1
  • python version: 3.8.10
  • operating system: Windows 10

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions