refactor(docs): more conversions of sh to console for copy-paste #10666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cranelift
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "fuzzing", "isle", "wasmtime:docs"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
dicej
reviewed
Apr 24, 2025
There was a problem hiding this comment.
There are several blocks you've marked console which include $ prompts and/or command output (I've added inline comments for a few, but then got tired of repeating myself). I'm thinking those should all be marked shell-session given they can't be meaningfully cut-and-pasted, correct?
This commit udpates more instructions on various READMEs to avoid `$` for easy copy-pasting, and also use `console` where appropriate. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
refactor(docs)=update-code-blocks
branch
from
74eefc8 to
4cbc146
Compare
dicej
approved these changes
Apr 24, 2025
|
Thanks for the reviews @dicej ! Addressed the feedback 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit udpates more instructions on various READMEs to avoid
$for easy copy-pasting, and also useconsolewhere appropriate.