-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
HID bugfix: SET_IDLE uses wValueH for duration, not wValueL #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mdevaev
wants to merge
1
commit into
arduino:master
Choose a base branch
from
mdevaev:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory usage change @ 2c2bb33
Click for full report table
Click for full report CSV
|
It is very likely that the ARM core and all other cores need that fix as well! |
algernon
added a commit
to keyboardio/KeyboardioHID
that referenced
this pull request
Sep 28, 2021
Based on arduino/ArduinoCore-avr#422, we need to use `wValueH` rather than `wValueL` when handling the `HID_SET_IDLE` request, according to the USB spec. Fixes #71. Signed-off-by: Gergely Nagy <algernon@keyboard.io>
obra
pushed a commit
to keyboardio/Kaleidoscope
that referenced
this pull request
Dec 14, 2023
Based on arduino/ArduinoCore-avr#422, we need to use `wValueH` rather than `wValueL` when handling the `HID_SET_IDLE` request, according to the USB spec. Fixes #71. Signed-off-by: Gergely Nagy <algernon@keyboard.io>
obra
pushed a commit
to keyboardio/Kaleidoscope
that referenced
this pull request
Dec 14, 2023
Based on arduino/ArduinoCore-avr#422, we need to use `wValueH` rather than `wValueL` when handling the `HID_SET_IDLE` request, according to the USB spec. Fixes #71. Signed-off-by: Gergely Nagy <algernon@keyboard.io>
This comment was marked as duplicate.
This comment was marked as duplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The duration in the SET_IDLE request is actually responsible for the highest byte, not the lowest. Here is an excerpt from the standard:

To verify this, I used USBCV, the official tool for testing compliance with USB standards. Without this patch, the "Idle Test" was a failure, everything works as it should with the patch.), the official tool for testing compliance with USB standards. Without this patch, the "Idle Test" was a failure, everything works as it should with the patch.