Skip to content

Improve Knuth-Morris-Pratt's String Search #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2019
Merged

Improve Knuth-Morris-Pratt's String Search #14

merged 3 commits into from
Oct 16, 2019

Conversation

Yee172
Copy link
Contributor

@Yee172 Yee172 commented Oct 15, 2019

The original code.js has both display and correctness errors.
@Yee172
Improve Knuth-Morris-Pratt's String Search
8274f4b 
The original code.js has both display and correctness errors.
@Yee172
Copy link
Contributor Author

Yee172 commented Oct 15, 2019

How to solve this "build failed" problem?

It seems that most of the code.js files share the same errors, which are

error     Missing the code folding for importing visualization libraries.
error     Missing the code folding for defining tracer variables.
error     Missing the code folding for visualizing.
@Yee172
Reconstruct Knuth-Morris-Pratt's String Search/code.js
cf37545 
1. Add code foldings
2. Delete log tracer to simplify the content
3. Delete redundant display steps
4. Indent using 4 spaces
5. Rename variables
6. Use fixed pattern and string to illustrate
@Yee172 Yee172 closed this Oct 16, 2019
@Yee172 Yee172 reopened this Oct 16, 2019
@64json
Copy link
Member

64json commented Oct 16, 2019

Awesome job and thanks for adding the code folding on other files also!
@64json 64json merged commit a6f8cd5 into algorithm-visualizer:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Yee172 @64json