Skip to content

refactor: Cycledetection.js and added tests #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2022
Merged

refactor: Cycledetection.js and added tests #1099

merged 1 commit into from
Sep 15, 2022

Conversation

10kartik
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • Fixes: Improper and incomplete implementation of CycleDetection.js #1097
@appgurueu appgurueu added code quality Code quality improvement tests Adds or fixes tests; issue that points out bugs in the tests labels Sep 13, 2022
@raklaptudirm raklaptudirm changed the title Refactor Cycledetection.js and added it's test. Sep 15, 2022
@raklaptudirm raklaptudirm merged commit cf0593f into TheAlgorithms:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code quality improvement tests Adds or fixes tests; issue that points out bugs in the tests
3 participants
@10kartik @appgurueu @raklaptudirm