Skip to content

Support for Base64url with case insensitive padding #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 19, 2022
Merged

Support for Base64url with case insensitive padding #219

merged 17 commits into from
Sep 19, 2022

Conversation

prince-chrismc
Copy link
Collaborator

resolve #205
prince-chrismc
prince-chrismc commented Mar 16, 2022
View reviewed changes
Copy link
Collaborator Author

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love a sanity check but I think I found an easy way to fix the base64url capitalization bug
@prince-chrismc prince-chrismc marked this pull request as ready for review September 19, 2022 02:58
@prince-chrismc
Copy link
Collaborator Author

@Thalhammer When you have a chance, I'd love a second set of eyes to double check my logic 🙏
@Thalhammer
Copy link
Owner

Looks good to me ;)
@prince-chrismc prince-chrismc merged commit 0628011 into Thalhammer:master Sep 19, 2022
@prince-chrismc prince-chrismc deleted the base64url-lower branch September 19, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@prince-chrismc @Thalhammer