Skip to content

Create Samuel 1st #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 178 commits into from

Conversation

Qhallmhie0012
Copy link

The guide below provides the flow for creating a perfect pull request to the Telegram X Repository. Before submitting your PR, ensure that it complies with the following principles.

Perfect PRs must be:

  • Rational. Explain the changes you've made. Be explicit and describe the changes in a few short, concise sentences.
  • Completed. All changes are properly tested and ready to be merged.
  • Up-To-Date. Your PR is based on the latest commit of the 'main' branch.

When fixing issues, make sure that your PR is:

  • Sufficient. Changes must fix the cause of an issue, not its effects.
  • Separated. Different bug fixes are divided into independent PRs.
  • Linked. If you fix a specific issue, add it to the title and its description to the body.
  • Creating. The fix does not break anything in other interfaces or on specific devices.
  • Consistent. Use the proper design relevant to the issue. If the design is missing, the PR must include at least two screenshots (before and after the changes).

When adding features, expect:

  • Discussion. If you implement a feature that requires a new design for the app, be ready to receive and follow comments or edit suggestions.
  • Dismissal. If the feature design you submitted is below our expectations, if it cripples the UX, or the feature-to-user impact is minor, your PR will be declined. All the features must strictly follow the Telegram X flow – matching the overall quality, stability, and the general style of the app.

Other contributions:

PR types not mentioned above can be considered as well, provided they are rational. For example, optimizations of existing features or the app build time (for this, before/after timing is mandatory). For code refactoring, the code should be clearly improved/simplified/more convenient and is expected to be free of any edge-case bugs.

Good luck and thanks for the contribution!

vkryl and others added 30 commits April 27, 2024 19:28
1. Fix losing custom notification channel settings
2. Fix reaching the notification channel limit
3. Fix missing notification channel groups when using multiple accounts
4. Fix other issues impacted by this root cause
…All Notifications`

This fixes seeing duplicate notification categories in system settings immediately after performing `Reset All Notifications` and possibly some other issues until app restart. This bug was causing issues only until app restart: old channels are always checked and removed during app initialization.
This fixes preview of video messages recorded by iOS app, looping of partially broken GIFs, and possibly some more edge cases
* LTR emoji fix

* Update Text.java

* Revert "Update Text.java"

This reverts commit 528a70c.

* Text.FLAG_IGNORE_NEWLINES fix

* Update

* Update

* Update

* Fix

* Update

* Rework LTR emoji workaround

* Move LTR emoji utils to `EmojiBidi.kt`

* Optimize imports

* Fix incorrect ranges in `EmojiBidi.kt`

* Get rid of `Strings.isWeakRtl`

* Remove unused code

---------

Co-authored-by: Vyacheslav <6242627+vkryl@users.noreply.github.com>
1. Max number of reactions per post setting
2. Custom emoji support when displaying polls and quizes
3. Phrase and word-based SMS codes supports
4. New advertisement API support
vkryl and others added 28 commits June 10, 2024 03:50
* Try to improve implementation of ViewPagerHeaderViewCompact.onSelectionChanged

* Fix fading

* Add ViewPagerTopView.getMaxStableWidth

* Clamp position offset
…GX-Android#654)

* Copy name and preview emoji status

* Update

* Fixes

* Pass `chatId` instead of chat object

* Remove try-catch. If there is a bug, it should be properly fixed, not suppressed

* Add `FormattedText.customEmoji` + Add `EmojiCodes.kt` + Code style fixes

* Add copyright comment

---------

Co-authored-by: vkryl <6242627+vkryl@users.noreply.github.com>
* Check for tabs horizontal gravity

* Animate item width change

* Fix ViewPagerTopView.getItemWidth. Add ViewPagerTopView.getItemExpandedWidth

* Fix item change animation

* Fix topViewTranslationX

* Fix topViewTranslationX TGX-Android#2

* Reset from/to on scroll state changed

* Animate filter icon appearance and disappearance

* Fix filter menu positioning

* Fix icon span animation
* Icons and Strings

* Playback Speed

* Update Counter

* Colors update

* Update

* Pitch update

* Update Text.java

* Update gesture

* Update PlaybackSpeedLayout.java

* Update strings

* Update ThrottlingRunnable.java

* Update

* Update

* Update

* Update PlaybackSpeedLayout.java

* Fizes

* Add missing copyright comments

---------

Co-authored-by: Vyacheslav <6242627+vkryl@users.noreply.github.com>
* Seekbar

* Update

* Update RoundProgressView2.java

* Update TGMessageVideo.java

* Update

* Update ThrottlingRunnable.java

* Fixes

* Fixes + Optimizations

* Delete ThrottlingRunnable.java

* Fixes

* Fixes

* Fix for non-bubble mode

* Fix

* Update

* Fixes

* Update RoundProgressView2.java

* Update

* Fix

* Update TGMessageVideo.java

* Update

* Update

---------

Co-authored-by: Vyacheslav <6242627+vkryl@users.noreply.github.com>
* Quotes

* Samsung keyboard fix

* Emoji fix

* Remove background, message layout fixes

* Fix

* Fixes

* More fixes

* Input filter fix

* Update ThemeCustom.java

* Fix

* Color Updates

* TextFormattingUpdate

* Update Text.java

* Update

* Uodate

* Update MessagesController.java

* Fix

* Add Copyright and remove unused code

* Update

* Fiz

* [Experimental] NoClipEditText fix for actual Android versions.

* Update
* Update

* Add some tooltips

* Fixes

* Update TGPlayerController.java

* Update

* Update

* Update Recorder

* Voice recording pause

* Update

* Update

* Round pause v1

* Update

* Update

* Update RecordAudioVideoController.java

* Update themes

* Update

* Update RecordAudioVideoController.java

* Update RecordAudioVideoController.java

* Minor fixes

---------

Co-authored-by: vkryl <6242627+vkryl@users.noreply.github.com>
* Update MediaViewController.java

* schedule voices fix

* Update voice.c

* Fix

* Update FileComponent.java
@Qhallmhie0012 Qhallmhie0012 changed the base branch from main to libyuv-upgrade August 25, 2024 06:59
@vkryl vkryl closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet