Skip to content

fix typos #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 13, 2022
Merged

fix typos #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5d334aa
Update 6_Booleans.ipynb
almogfishel Jul 5, 2021
445a554
Merge pull request #1 from almogfishel/almogfishel-patch-1
almogfishel Jul 6, 2021
5f4d716
Update 2_Arithmetics.ipynb
almogfishel Feb 27, 2022
68926ce
Merge branch 'PythonFreeCourse:master' into master
almogfishel Feb 27, 2022
727c933
Update 4_Lists.ipynb
almogfishel Feb 27, 2022
a38b149
Update 5_String_Methods.ipynb
almogfishel Feb 27, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion week01/2_Arithmetics.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@
"\n",
"<p style=\"text-align: right; direction: rtl; float: right;\">כאשר אנחנו עושים חלוקת שלמים מהצורה <code>A // B</code>, אנחנו למעשה מתכוונים לשאול:</p>\n",
"\n",
"<blockquote style=\"text-align: left; direction: ltr; float: right; border-left: 0; border-right: 5px solid #eeeeee;\"><p style=\"text-align: right; direction: rtl; float: left;\">אם יש לי A משולשי פיצה, וחילקתי את כל משלושי הפיצה באופן שווה ל־B ילדים (תזהרו מלחתוך לי את המשולשים!), כמה משולשי פיצה יקבל כל ילד?</p></blockquote>\n",
"<blockquote style=\"text-align: left; direction: ltr; float: right; border-left: 0; border-right: 5px solid #eeeeee;\"><p style=\"text-align: right; direction: rtl; float: left;\">אם יש לי A משולשי פיצה, וחילקתי את כל משולשי הפיצה באופן שווה ל־B ילדים (תזהרו מלחתוך לי את המשולשים!), כמה משולשי פיצה יקבל כל ילד?</p></blockquote>\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch :D
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

קרדיט לאופיר!
"\n",
"<p style=\"text-align: right; direction: rtl; float: right;\">לדוגמה: הביטוי <code>4 // 9</code>, אומר שיש לנו 9 משולשי פיצה ו־4 ילדים רעבים.<br>אם נחלק את משולשי הפיצה בין הילדים, נגלה שכל ילד יקבל 2 משולשים, ושנשאר משולש אחד שלא ניתן לחלק.</p>"
]
Expand Down
2 changes: 1 addition & 1 deletion week02/4_Lists.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,7 +1004,7 @@
"print(\"1. 'Moshe' in pupils == \" + str('Moshe' in pupils))\n",
"print(\"2. 'Moshe' in pupils[0] == \" + str('Moshe' in pupils[0]))\n",
"print(\"3. ['Moshe', 'Splinter'] in pupils == \" + str(['Moshe', 'Splinter'] in pupils))\n",
"print(\"4. ['Moshe', 'Splinter'] in pupils[0] == \" + str(['Moshe', 'Splinter'] in pupils[-1]))\n",
"print(\"4. ['Moshe', 'Splinter'] in pupils[-1] == \" + str(['Moshe', 'Splinter'] in pupils[-1]))\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

זה מכוון, לדעתי :) אמור לצאת כאן False
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

התוצאה היא עדיין False, שיניתי רק את ההדפסה שתתאים לפעולה :)
"print(\"5. ['Moshe', 'Dukasit', 'Splinter'] in pupils == \" + str(['Moshe', 'Dukasit', 'Splinter'] in pupils))\n",
"print(\"6. ['Moshe', 'Dukasit', 'Splinter'] in pupils[0] == \" + str(['Moshe', 'Dukasit', 'Splinter'] in pupils[0]))"
]
Expand Down
2 changes: 1 addition & 1 deletion week02/5_String_Methods.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,7 +1112,7 @@
" </div>\n",
" <div style=\"width: 90%\">\n",
" <p style=\"text-align: right; direction: rtl; clear: both;\">\n",
" יש נטייה לשכוח את ה־<em>s</em> אחרי ה־<em>end</em> או את ה־<em>start</em> ב־<em>end<strong>s</strong>with</em> וב־<em>start<strong>s</strong>with</em>.\n",
" יש נטייה לשכוח את ה־<em>s</em> אחרי ה־<em>end</em> או ה־<em>start</em> ב־<em>end<strong>s</strong>with</em> וב־<em>start<strong>s</strong>with</em>.\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

אישית, מעדיף את הצורה היותר מפורשת לפני השינוי ^^"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

אני חושבת שלפני זה לא אומר את מה שאתה מתכוון, בעיניי זה מציב את ה-start כדבר השני שעלול להישכח
" </p>\n",
" </div>\n",
"</div>"
Expand Down