-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Improving accessibility of telegram #1713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Improving accessibility of telegram #1713
Conversation
4284193
to
c1e9c85
Compare
I fixed bug,when percents not announced if user not vote and poll was closed. Also i added announcing during loading of some content. |
48ce9b5
to
d7a3c77
Compare
d7a3c77
to
eba5614
Compare
eba5614
to
fb194c0
Compare
fb194c0
to
60ad3de
Compare
@@ -765,8 +791,11 @@ public static class PollButton { | |||
private Drawable[] selectorDrawable = new Drawable[2]; | |||
private int[] selectorDrawableMaskType = new int[2]; | |||
private RectF instantButtonRect = new RectF(); | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
default boolean needPlayMessage(MessageObject messageObject, boolean muted) { | ||
return false; | ||
} | ||
|
||
default boolean drawingVideoPlayerContainer() { | ||
return false; | ||
return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reformat code pls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version: '2.320.0'mm
Operating System
Runner Image
Runner Image Provisioner
GITHUB_TOKEN Permissions
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v4' (SHA:11bd71901bbe5b1630ceea73d27597364c9af683)
Complete job name: danger-js
2s
Run actions/checkout@v4
Syncing repository: twentyhq/twenty
Getting Git version info
Temporarily overriding HOME='/home/runner/work/_temp/ba5e88dd-2c77-4246-927f-6c28727b290c' before making global git config changes
60ad3de
to
e9ef932
Compare
@qwq233 Now all ok? I updated commit via amend |
ffa5933
to
d947ae7
Compare
2280c8a
to
0ebbc8a
Compare
3c60c0a
to
b34f0db
Compare
007abda
to
4429061
Compare
c633f05
to
d428252
Compare
3c85cf1
to
18d17c0
Compare
it's bad idea to mix prs (accesibility + mem leak), also, the smaller the prs the higher chance of being merged. |
partial merges of PRs is a pita, it's better to send one pr for accesibility thing and another for memleak fix. |
518c27e
to
970f511
Compare
This branch has conflicts that must be resolved |
ba13cf9
to
505a35f
Compare
505a35f
to
3dd3bcd
Compare
In this pr i suggest several accessibility fixes and improvements.
known issues.
All issues,which known on this moment,connected with accessibility scrolling of chat.
Even with this issues in my opinion accessibility scrolling become more better,when message contains alot of text,so if @xaxtix will merge my pr and fix issues,about which i wrote,blind users shouldn't swipe alot of times,if message have alot of text,because for now in official telegram for large messages we,blind users,should swipe sometimes ten,twenty or more times,to go to the next node,if message contains alot of text. Especially it actual,when we swipe right,i.ecall action scroll_forward.