-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Theme accents #1525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexvasilkov
wants to merge
13
commits into
DrKLO:master
Choose a base branch
from
alexvasilkov:dev_theme_accent
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Theme accents #1525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvasilkov
commented
Aug 22, 2019
- Tinting: I tried to come up with tinting formula that would better preserve contrast between texts and backgrounds. Though black accent for Dark theme or white accent for Arctic theme will still make texts unreadable.
- Perfromance: There is no performance impact if default (blue) accent color is selected. In case of other accent colors there will be imperceptible extra load during theme initialization (1ms on Samsung S10+, 9ms on old Nexus 5), but during regular app usage there will be no extra load.
- Fixed:
- Accent color wasn't correctly tinted in few places. E.g. message input cursor, new group image background, etc.
- Text handling controls used blue color set in Android theme, I changed them to neutral grey to not conflict with accent colors.
- Opening Theme Preview screen was rewriting local user's theme with same name, even if Cancel button is pressed.
- Migration: Users who used old Dark theme (either as current or as night theme) will be switched to Dark Blue theme with grey accent after update, since it is quite close to original Dark theme. As alternative we can save old Dark theme as user's custom theme to keep it exactly the same.
- Theme sharing: When sharing Dark or Arctic theme with accent color applied all colors will be saved as already tinted.
- Feature suggestion: We can allow using different accent colors for different user accounts, so that the user can easily understand which account he is currently under just from accent color. We can save theme accent to account-specific perefences right away, or add extra switch like "Use separate colors for different accounts", though it may complicate Settings screen UI.
- Known issue: PhotoViewer does not use themes mechanizm, all colors are hardcoded there, so it won't be tinted with accent color. To fix this we'll need to replace all hardcoded colors with themed one, but this should probably be done as a separate task since it may require introducing new colors in existing themes (e.g. we still need to use light text colors even in light themes).
- Other: I reused Theme Preview screen as custom color picker screen.
# Conflicts: # TMessagesProj/src/main/assets/dark.attheme
He does not accept pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.