-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Fix issues when building with clang/libc++. #1483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This was only building successfully by chance. Without this, avutil inherits some values from any modules defined before it. When using libc++ instead of gnustl, it would wrongly export the libandroid_support headers in the wrong order, breaking the build.
This is a pointer. It can't be less than zero. Clang treats this as an error.
0d0f722
to
7b8f6f3
Compare
The latter is gnustl specific.
Use std::min/std::max from <algorithm> rather than the macros used for C since the macros will collide with things like numeric_limits::max.
7b8f6f3
to
96ad5e3
Compare
When I try to build your code with NDK 18.1, I see the following error |
That's expected. All this change does is allow people to switch to Clang and libc++; it doesn't change this project's default configuration. In your testing you only switched to libc++, not clang. Remove the |
While syncing the project in android studio i am getting and i tried using NDK 15 and 16 as well |
carotkut94 |
Actually i did that to, and now i am getting something like this, here i am using android ndk 15c |
Older versions it was written to use android-ndk-r16b. |
Whenever I download ndk from android studio itself, it just installs ndk19, should i just install android-ndk-r16b? |
i downloaded just android-ndk-r16b and show it |
Hello. org.gradle.execution.MultipleBuildFailures: Build completed with 1 failures. Thanks |
I got this error when running ndk-build using NDK 16b in Windows my Android.mk arm64-v8a] Compile : tmessages.29 <= audio.c Please help, thank you |
just FYI. After I posted here in the last October, all of my build problem were resolved by switching to Telegram-FOSS: good luch! |
Hello. E:\Telegram531\TMessagesProj\property(interface org.gradle.api.file.Directory, transform(property(interface org.gradle.api.file.Directory, fixed(class org.gradle.api.internal.file.DefaultProjectLayout$FixedDirectory, E:\Telegram531\TMessagesProj\build))))\AndroidManifest.xml (Синтаксическая ошибка в имени файла, имени папки или метке тома) |
*I changed the line if (info->video_stream <= 0) { into if (info->video_stream <= (void )0) { in the gifvideo.cpp file. And it build the library until finished. But when run building the debug version got another error Caused by: org.gradle.internal.UncheckedException: Build command failed.
Caused by: Build command failed.
Any help please, thank you |
Please someone help me with this error. WARNING: API 'variantOutput.getProcessManifest()' is obsolete and has been replaced with 'variantOutput.getProcessManifestProvider()'. |
I switch working on my Mac OS, and set Build jni library using NDK 16b, it is working just fine. The problem only using Windows OS. |
I am still not able to build the project from the latest code, i dont understand why the documents are not complete about building it. Build command failed. In file included from C:/Users/DeathCode/Desktop/Telegram/TMessagesProj/jni/libtgvoip/./audio/AudioOutput.cpp:19: make: *** [C:/Users/DeathCode/Desktop/Telegram/TMessagesProj/build/intermediates/ndkBuild/afat/debug/obj/local/arm64-v8a/libcrypto_arm64-v8a.a] Error 87 |
This link will fix this issue. |
https://stackoverflow.com/q/52670082/632035 alludes to issues when building with Clang and libc++. Fix those issues.