Skip to content

Fix. For privacy reasons, we should give priority to internal storage cache #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix. For privacy reasons, we should give priority to internal storage cache #1467

wants to merge 1 commit into from

Conversation

eugeniobaglieri
Copy link

Cache directory contains all thumbnails and image (also from secret chat). So we should check first if a private internal storage is available, and, if not, fallback to external.
We should save them in internal storage instead of publicly accessible external storage cache.

Cache directory contains all thumbnails and image from secret chat.
We should save them in internal storage instead of publicly accessible external storage cache.
@eugeniobaglieri eugeniobaglieri changed the title For privacy reasons, we should give priority to internal storage cache Mar 1, 2018
@sphinxy
Copy link

sphinxy commented Jul 17, 2019

It makes sense to use ExternalCache for normal chats, those data is not very important normally and since cache for telegram typically is big, external storage is preferable.

But for secret chat it really mandatory to use internal cache which is not accessible by any other apps. Otherwise, your secret image of boobs can be viewed by any apps.

@sidahmed-malaoui
Copy link

This methodology is most. Telegram should use a private storage for cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants