Skip to content

Add a setting for using system emoji #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

39bit
Copy link

@39bit 39bit commented Jul 14, 2017

Some leftover commented code uncommented, as well as new code added to make the emoji panel work properly.

A translation string already exists, so adding a setting was trivial.

The emoji panel uses scaling with an oversized font, the size of which is measured and then scaled accordingly.

Under replaceEmoji, the MessagesController.getInstance().useSystemEmoji if condition was moved lower down to allow links and other formatting to still work even if the setting is enabled.

The allowBigEmoji / draw single big emoji setting remains unimplemented in this PR.

@ghost
Copy link

ghost commented Jul 14, 2017

Does this fix the bug with useSystemEmoji breaking entities (links, mentions, hashtags, formatted text all show up as plain text) that exists since build 1026?

@39bit
Copy link
Author

39bit commented Jul 14, 2017

@nyuszika7h Yes, see:

"Under replaceEmoji, the MessagesController.getInstance().useSystemEmoji if condition was moved lower down to allow links and other formatting to still work even if the setting is enabled."

@NatiSD
Copy link

NatiSD commented Jul 23, 2017

I found a bug at the new beta update.
When you open the photo editor and writing on the pic. If hou pressing on the back button to delete the app is freezing and not working.

And also i have seen sync problem in the bio on the url description of massages.

@39bit
Copy link
Author

39bit commented Jul 23, 2017

@NatiSD What does that have to do with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants