Use even numbers for resultWidth & resultHeight (video transcoding) #1429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had an issue (reproduced in your App) when transcoding from a 620x714 video input to a scaled down 555x640 output. The encoder was throwing during configuration. After some research this is apparently caused by odd output sizes (in the sample 555). Just by rounding to nearest even number this issue gets fixed. I added the rounding code to the VideoEditorActivity.java since is where those values are being computed and the rounding happens, but this could be done/checked later on during transcoding in MediaController.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had an issue (reproduced in your App) when transcoding from a 620x714 video input to a scaled down 555x640 output. The encoder was throwing during configuration. After some research this is apparently caused by odd output sizes (in the sample 555). Just by rounding to nearest even number this issue gets fixed.
I added the rounding code to the VideoEditorActivity.java since is where those values are being computed and the rounding happens, but this could be done/checked later on during transcoding in MediaController.