Skip to content

Reducing the function calls by simply creating a variable #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aravindkanna
Copy link

Here in the ActionBarMenu.java the function getChildCount() is being called in the for loop in all iterations. Instead creating a variable can make this simple I guess.

DrKLO pushed a commit that referenced this pull request Jun 24, 2016
@@ -6,6 +6,6 @@ buildscript {
}
dependencies {
classpath 'com.android.tools.build:gradle:2.1.0'
classpath 'com.google.gms:google-services:2.1.0'
classpath 'com.google.gms:google-services:2.1.0-alpha3'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't match with your commit message.

@abcdeiko
Copy link
Contributor

abcdeiko commented Jul 6, 2016

@aravindkanna good job!
But you don't forget one of base rule: "One branch -> one feature". Therefore, you don't need to change gradle dependencies at this commit, i think.

@aravindkanna
Copy link
Author

aravindkanna commented Jul 6, 2016

@abcdeiko , Thank you.
so what should I do now? Create a new branch or change the current branch? Actually that was happened when I tried to merge. The fault was to commit before pulling the current remote.

@abcdeiko
Copy link
Contributor

abcdeiko commented Jul 6, 2016

@aravindkanna you don't need any action now, because DrKLO already merged your commit.
To prevent merge conflicts you can fetch last changes from master branch and rebase it on your working branch before create a new pull request.

@similato
Copy link

Thank you.

hrzhu pushed a commit to hrzhu/Telegram that referenced this pull request Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants