Deleted unused code and parameters in PhotoViewer and MediaController #1410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2016 11:23
Here are some reasons why unused code should be removed: For anyone new working on a project, they not only have to understand the working code, they have to understand unused material also. This is wasted time and creates confusion. There is a danger that at sometime someone will make a change which inadvertently involve the 'dormant' code and can introduce bugs. I know it's happened on projects I've worked on. The maintenance of any code is an administrative burden. By preserving old redundant code that burden is increased. For example, merging changes in the main branch becomes harder because there is more code to work through and more possibility to make a mistake. What happens over time is that more and more old unused code is added to the codebase. This increases the confusion, potential misunderstanding and administrative overhead. The chances that the unused code will ever be used again is very unlikely. With time that possibility of re-use diminishes. If code to be removed and is considered important enough then the code can be branched off and documented. Any personal feelings that a coder may have about code they may have worked hard on are understandable. But part of being professional requires that those thoughts have to put to one side for the better good. Time stands for no-one and there is no place for preserving historical code in a working codebase.
Just deleted unused parameters in method declarations and more commented code I have found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday, I found lot of commented code at PhotoViewer and MediaController so I decided help a little with it. I've just removed all commented code I've seen and unused parameters at methods declarations.
The main reason is YAGNI: you ain't gonna need it, and it only increases complexity in the code.
The reason why I've deleted commented code lines can be found in this commit: a369df5
Hope it helps!