Skip to content

Move AbstractAdapter#valid_type? to a class method #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025

Conversation

aidanharan
Copy link
Contributor

Refactor native database types for rails/rails#54875

Fixes (https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/14670746703/job/41176483142?pr=1325):

  1) Error:
ActiveRecord::AdapterTest#test_invalid_column:
NameError: undefined local variable or method 'native_database_types' for class ActiveRecord::ConnectionAdapters::SQLServerAdapter
    /usr/local/bundle/bundler/gems/rails-99e27fa586af/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:894:in 'ActiveRecord::ConnectionAdapters::AbstractAdapter.valid_type?'
    /usr/local/bundle/bundler/gems/rails-99e27fa586af/activerecord/test/cases/adapter_test.rb:57:in 'ActiveRecord::AdapterTest#test_invalid_column'

  2) Error:
ActiveRecord::AdapterTest#test_valid_column:
NameError: undefined local variable or method 'native_database_types' for class ActiveRecord::ConnectionAdapters::SQLServerAdapter
    /usr/local/bundle/bundler/gems/rails-99e27fa586af/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:894:in 'ActiveRecord::ConnectionAdapters::AbstractAdapter.valid_type?'
    /usr/local/bundle/bundler/gems/rails-99e27fa586af/activerecord/test/cases/adapter_test.rb:51:in 'block in ActiveRecord::AdapterTest#test_valid_column'
    /usr/local/bundle/bundler/gems/rails-99e27fa586af/activerecord/test/cases/adapter_test.rb:49:in 'Hash#each_key'
    /usr/local/bundle/bundler/gems/rails-99e27fa586af/activerecord/test/cases/adapter_test.rb:49:in 'ActiveRecord::AdapterTest#test_valid_column'
@aidanharan aidanharan marked this pull request as ready for review April 25, 2025 19:15
@aidanharan aidanharan merged commit 6feabc2 into main Apr 25, 2025
9 of 10 checks passed
@aidanharan aidanharan deleted the allow-column-type-check-without-connection branch April 25, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant