Improve error messages.

Author: levlam

td/telegram/files/FileLoaderUtils.cpp

@@ -318,33 +318,35 @@ Result<FullLocalLocationInfo> check_full_local_location(FullLocalLocationInfo lo
   } else if (!are_modification_times_equal(location.mtime_nsec_, stat.mtime_nsec_)) {
     VLOG(file_loader) << "File \"" << location.path_ << "\" was modified: old mtime = " << location.mtime_nsec_
                       << ", new mtime = " << stat.mtime_nsec_;
-    return Status::Error(400, PSLICE() << "File \"" << utf8_encode(location.path_) << "\" was modified");
+    return Status::Error(400, "File was modified");
   }
   if (skip_file_size_checks) {
     return std::move(local_info);
   }
 
-  auto get_file_size_error = [&](Slice reason) {
-    return Status::Error(400, PSLICE() << "File \"" << utf8_encode(location.path_) << "\" of size " << size
-                                       << " bytes is too big" << reason);
+  auto get_file_size_error = [&](Slice reason, int64 max_size) {
+    return Status::Error(400, PSLICE() << "File of size " << size << " bytes is too big" << reason
+                                       << "; the maximum size is " << max_size << " bytes");
   };
   if ((location.file_type_ == FileType::Thumbnail || location.file_type_ == FileType::EncryptedThumbnail) &&
       size > MAX_THUMBNAIL_SIZE && !begins_with(PathView(location.path_).file_name(), "map") &&
       !begins_with(PathView(location.path_).file_name(), "Album cover for ")) {
-    return get_file_size_error(" for a thumbnail");
+    return get_file_size_error(" for a thumbnail", MAX_THUMBNAIL_SIZE);
   }
   if (size > MAX_FILE_SIZE) {
-    return get_file_size_error("");
+    return get_file_size_error("", MAX_FILE_SIZE);
   }
   if (get_file_type_class(location.file_type_) == FileTypeClass::Photo && size > MAX_PHOTO_SIZE) {
-    return get_file_size_error(" for a photo");
+    return get_file_size_error(" for a photo", MAX_PHOTO_SIZE);
   }
-  if ((location.file_type_ == FileType::VideoNote || location.file_type_ == FileType::SelfDestructingVideoNote) &&
-      size > G()->get_option_integer("video_note_size_max", DEFAULT_VIDEO_NOTE_SIZE_MAX)) {
-    return get_file_size_error(" for a video note");
+  if (location.file_type_ == FileType::VideoNote || location.file_type_ == FileType::SelfDestructingVideoNote) {
+    auto max_size = G()->get_option_integer("video_note_size_max", DEFAULT_VIDEO_NOTE_SIZE_MAX);
+    if (size > max_size) {
+      return get_file_size_error(" for a video note", max_size);
+    }
   }
   if (location.file_type_ == FileType::VideoStory && size > MAX_VIDEO_STORY_SIZE) {
-    return get_file_size_error(" for a video story");
+    return get_file_size_error(" for a video story", MAX_VIDEO_STORY_SIZE);
   }
   return std::move(local_info);
 }