Skip to content

Commit 7e29e37

Browse files
author
Pat Mellon
committed
[PYT-298] Address general compactness
1 parent 864d4b5 commit 7e29e37

10 files changed

+111
-58
lines changed

‎_layouts/blog.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55
<body class="{{ page.body-class }}">
66
{% include header.html %}
77

8-
<div class="main-background {{ page.background-class }}"></div>
8+
<div class="main-background blog-background"></div>
99

1010
{% assign posts = paginator.posts %}
1111
{% assign display_post_categories = site.posts | map: 'categories' | join: ',' | replace: '-', ' ' | split: ',' | uniq | sort %}
1212
{% assign current_page = page.url | downcase | remove: ".html" | split: '/' %}
1313
{% assign post_categories = site.posts | map: 'categories' | join: ',' | split: ',' | uniq | sort %}
1414

1515
<div class="jumbotron jumbotron-fluid">
16-
<div class="container blog-page-container">
16+
<div class="container">
1717
{% for post in posts limit:1 %}
1818
<p class="featured-post">Featured Post</p>
1919
<h1>

‎_layouts/blog_detail.html

+5-5
Original file line numberDiff line numberDiff line change
@@ -3,25 +3,25 @@
33
{% include head.html %}
44

55
<body class="blog">
6-
<div class="main-background {{ page.background-class }}"></div>
6+
<div class="main-background blog-background blog-detail-background"></div>
77

88
<div class="container-fluid header-holder blog-detail-header">
99
<div class="container">
1010
{% include nav.html %}
1111
</div>
1212
</div>
1313

14-
<div class="jumbotron jumbotron-fluid">
14+
<div class="jumbotron jumbotron-fluid blog-detail-jumbotron">
1515
<div class="container blog-detail-container">
16-
<p class="blog-date">{{ page.date | date: '%B %d, %Y' }}</p>
16+
<p class="featured-post">{{ page.date | date: '%B %d, %Y' }}</p>
1717
<h1>
1818
<a class="blog-title">{{ page.title }}</a>
1919
</h1>
2020
</div>
2121
</div>
2222

23-
<div class="main-content-wrapper">
24-
<div class="main-content">
23+
<div class="main-content-wrapper blog-detail-wrapper">
24+
<div class="main-content blog-detail-content">
2525
<div class="container">
2626
<img src="{{ site.baseurl }}/assets/images/logo-icon.svg" class="img-fluid author-icon">
2727
<article class="pytorch-article">

‎_sass/base_styles.scss

+5-1
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,10 @@ a, .btn {
147147
&.features-background {
148148
background-image: url($baseurl + "/assets/images/features-background.jpg");
149149
}
150+
151+
&.blog-background {
152+
background-image: url($baseurl + "/assets/images/blog-background.jpg");
153+
}
150154
}
151155

152156
.bg-light-grey {
@@ -269,7 +273,7 @@ a, .btn {
269273
}
270274

271275
.tweet {
272-
margin-bottom: 2.5rem;
276+
margin-bottom: 2.2rem;
273277
word-wrap: break-word;
274278

275279
a {

‎_sass/blog.scss

+46-15
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,28 @@
33
color: $black;
44
}
55

6+
.main-content {
7+
padding-bottom: 1.5rem;
8+
@include desktop {
9+
padding-top: 1.70rem;
10+
padding-bottom: 3.5rem;
11+
}
12+
}
13+
14+
.main-background {
15+
height: 275px;
16+
17+
@include desktop {
18+
height: 461px;
19+
}
20+
}
21+
22+
.blog-detail-background {
23+
@include desktop {
24+
height: 312px;
25+
}
26+
}
27+
628
.main-content-menu {
729
.navbar-nav .nav-link {
830
text-transform: capitalize;
@@ -31,6 +53,7 @@
3153
}
3254

3355
.main-content-wrapper {
56+
margin-top: 275px;
3457
.row.blog-index {
3558
margin-top: 30px;
3659
p {
@@ -54,7 +77,7 @@
5477
}
5578

5679
.col-md-4 {
57-
margin-bottom: rem(140px);
80+
margin-bottom: rem(23px);
5881
}
5982
}
6083

@@ -85,25 +108,27 @@
85108
}
86109
}
87110

111+
.blog-detail-content {
112+
padding-bottom: 2.8rem;
113+
}
114+
115+
.blog-detail-wrapper {
116+
@include desktop {
117+
margin-top: 234px + $desktop_header_height;
118+
}
119+
}
120+
88121
.jumbotron {
89122
@include desktop {
90-
height: 380px;
123+
height: 405px;
91124
}
92125

93126
.container {
94-
padding-top: rem(90px);
95127
@include desktop {
96128
padding-bottom: rem(45px);
97-
padding-top: 0;
98-
}
99-
@include small-desktop {
100-
padding-top: rem(90px);
101129
}
102130
}
103131

104-
background-image: url($baseurl + "/assets/images/blog-background.jpg");
105-
background-size: cover;
106-
107132
h1 {
108133
letter-spacing: -1.65px;
109134
font-size: rem(56px);
@@ -121,8 +146,12 @@
121146
color: $white;
122147
}
123148
}
149+
124150
.blog-detail-container {
125-
padding-top: rem(174px);
151+
padding-top: 5rem;
152+
@include desktop {
153+
padding-top: rem(174px);
154+
}
126155
}
127156

128157
p {
@@ -147,6 +176,12 @@
147176
}
148177
}
149178

179+
.blog-detail-jumbotron {
180+
@include desktop {
181+
height: 107px;
182+
}
183+
}
184+
150185
p.blog-date {
151186
@include blog_date_and_feature;
152187
color: $dark_grey;
@@ -181,11 +216,7 @@
181216
}
182217

183218
@media (max-width: 1067px) {
184-
.main-content-wrapper {
185-
margin-top: 0;
186-
}
187219
.jumbotron {
188-
position: inherit;
189220
h1 {
190221
margin-right: 0;
191222
a {

‎_sass/ecosystem.scss

+10-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
.ecosystem .jumbotron {
22
height: 170px;
33
@include desktop {
4-
height: 320px;
4+
height: 239px;
55
}
66

77
h1 {
@@ -21,15 +21,21 @@
2121
height: 275px;
2222

2323
@include desktop {
24-
height: 470px;
24+
height: 349px;
25+
}
26+
}
27+
28+
.ecosystem .main-content {
29+
@include desktop {
30+
padding-top: 3.25rem;
2531
}
2632
}
2733

2834
.ecosystem .main-content-wrapper {
2935
background-color: $light_grey;
3036

3137
@include desktop {
32-
margin-top: 380px + $desktop_header_height;
38+
margin-top: 260px + $desktop_header_height;
3339
}
3440
margin-top: 275px;
3541
}
@@ -39,7 +45,7 @@
3945
}
4046

4147
.ecosystem-cards-wrapper {
42-
margin-bottom: rem(80px);
48+
margin-bottom: rem(18px);
4349
padding-top: rem(20px);
4450
}
4551

‎_sass/features.scss

+11-4
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
.features {
2+
.main-content {
3+
padding-bottom: 0;
4+
}
25
.navbar-nav .nav-link {
36
color: $black;
47
}
@@ -9,7 +12,7 @@
912

1013
.main-background {
1114
@include desktop {
12-
height: 540px;
15+
height: 575px
1316
}
1417
}
1518
}
@@ -22,10 +25,14 @@
2225
margin-top: rem(20px);
2326
}
2427

28+
&:last-of-type {
29+
padding-bottom: rem(72px);
30+
}
31+
2532
@include desktop {
26-
padding-bottom: rem(115px);
33+
padding-bottom: rem(96px);
2734
&:first-of-type {
28-
margin-top: rem(63px);
35+
margin-top: 4.05rem;
2936
}
3037
}
3138

@@ -150,7 +157,7 @@
150157
padding-top: rem(30px);
151158
}
152159
@include desktop {
153-
height: 395px;
160+
height: 468px;
154161
h1 {
155162
padding-top: 0;
156163
}

‎_sass/footer.scss

+2-2
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@
5555
padding-bottom: rem(40px);
5656

5757
@include desktop {
58-
padding-top: rem(80px);
59-
padding-bottom: rem(80px);
58+
padding-top: rem(66px);
59+
padding-bottom: 4.09rem;
6060
}
6161

6262
h2 {

0 commit comments

Comments
 (0)