Skip to content

fix(vue): update output target and resolve type issues #30239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 13, 2025
Merged

fix(vue): update output target and resolve type issues #30239

merged 8 commits into from
Mar 13, 2025

Conversation

christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Mar 11, 2025 •
edited by brandyscarney
Loading

Issue number: fixes #30179

What is the current behavior?

There have been issues reported on version 8.4.3 related to the type information changing for Vue

What is the new behavior?

This patch updates the Vue components to be correctly types using a new version of the output target.

Does this introduce a breaking change?

  • Yes
  • No
@christian-bromann christian-bromann requested a review from a team as a code owner March 11, 2025 22:58
@vercel Vercel
Copy link

vercel bot commented Mar 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 6:27pm
@github-actions github-actions bot added package: core @ionic/core package package: vue @ionic/vue package labels Mar 11, 2025
@christian-bromann christian-bromann changed the title fix(vue): fix type issues with IonNav Mar 11, 2025
@christian-bromann
Copy link
Member Author

Released a dev build: @ionic/vue@8.4.4-dev.11741733932.1686c035

Verified reproduction case in #30221

Screenshot 2025-03-11 at 4 37 44 PM

Verified reproduction case in #30179

Screenshot 2025-03-11 at 4 43 36 PM

Important note: this only works if moduleResolution is set to "moduleResolution": "bundler", in the tsconfig.json. I think no one should still use the Node.js Classic way of resolving modules. bundler is I think a good alternative and requires so changes to the source code.
@brandyscarney brandyscarney changed the title fix(vue): fix type issues Mar 12, 2025
@brandyscarney brandyscarney mentioned this pull request Mar 13, 2025
Closed
@christian-bromann
Copy link
Member Author

christian-bromann commented Mar 13, 2025 •
edited
Loading

A dev build is available using the 8.4.4-dev.11741890362.1f34266d version. Thanks @brandyscarney
@brandyscarney brandyscarney enabled auto-merge March 13, 2025 20:26
@brandyscarney brandyscarney added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit 6dcb143 Mar 13, 2025
60 checks passed
@brandyscarney brandyscarney deleted the cb/vue-type-fix branch March 13, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package package: vue @ionic/vue package
2 participants
@christian-bromann @brandyscarney