Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ionic-team/ionic-framework
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.5.2
Choose a base ref
...
head repository: ionic-team/ionic-framework
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.5.3
Choose a head ref
  • 7 commits
  • 31 files changed
  • 6 contributors

Commits on Mar 26, 2025

  1. Configuration menu
    Copy the full SHA
    ca51d64 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    27816d1 View commit details
    Browse the repository at this point in the history
  3. merge release-8.5.2 (#30314)

    v8.5.2
    brandyscarney authored Mar 26, 2025
    Configuration menu
    Copy the full SHA
    23b7a29 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2025

  1. fix(checkbox): ensure proper visual selection when navigating via Voi…

    …ceOver in Safari (#30300)
    
    Issue number: resolves internal
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    <!-- Please describe the current behavior that you are modifying. -->
    Currently, MacOS voice over on Safari does not recognize ion-checkbox
    correctly and fails to highlight the element properly
    
    
    ## What is the new behavior?
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    By adding the role property to the host element, we're correctly
    identifying ion-checkbox as a checkbox so Safari knows how to handle it.
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [X] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    <!-- Any other information that is important to this PR such as
    screenshots of how the component looks before and after the change. -->
    
    ---------
    
    Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
    Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
    3 people authored Mar 28, 2025
    Configuration menu
    Copy the full SHA
    bb40a1e View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2025

  1. fix(overlays): exclude backdrop-no-scroll class when toast is present…

    …ed (#30123)
    
    Issue number: resolves #30112 
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    
    When toast is presented, the `backdrop-no-scroll` class is added to the
    body when using Frameworks like Angular. It should not add this class as
    toast does not be setting focus trap as mentioned in the
    [comments](https://github.com/ionic-team/ionic-framework/blob/1cfa915e8fe362951c521bce970a9f5f10918ab2/core/src/utils/overlays.ts#L514-L520).
    
    ## What is the new behavior?
    
    - Class is only added when the overlay that is presented is not a toast
    component.
    - Test was added.
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    N/A
    
    ---------
    
    Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
    tobiloeb and thetaPC authored Apr 1, 2025
    Configuration menu
    Copy the full SHA
    7f9df7a View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2025

  1. fix(segment-view): prevent vertical scroll while scrolling horizontal…

    …ly (#30276)
    
    Issue number: resolves #30001 
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    <!-- Please describe the current behavior that you are modifying. -->
    
    When segment view has content that is long enough to render outside of
    the viewport, then a user can scroll vertically and horizontally when
    the user scrolled down to see the content at the bottom. This causes
    disorientation as scrolling should only be in one direction.
    
    This only happens on a mobile device, specifically Android. It can be
    reproduce with a browser simulator.
    
    ## What is the new behavior?
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    
    - Updated styling to take into account that content might be outside of
    the viewport.
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    <!-- Any other information that is important to this PR such as
    screenshots of how the component looks before and after the change. -->
    
    Dev build: `8.5.2-dev.11743531350.19e040aa`
    thetaPC authored Apr 2, 2025
    Configuration menu
    Copy the full SHA
    105796f View commit details
    Browse the repository at this point in the history
  2. v8.5.3

    Ionitron committed Apr 2, 2025
    Configuration menu
    Copy the full SHA
    28e29c3 View commit details
    Browse the repository at this point in the history
Loading