Fix #574 - config changes bug with localized resources - No more AndroidViewModels #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardsurfer
approved these changes
Feb 8, 2019
andre-vm
reviewed
May 14, 2019
| return mNoTasksLabel; | ||
| } | ||
|
|
||
| public LiveData<Drawable> getNoTaskIconRes() { | ||
| public MutableLiveData<Integer> getNoTaskIconRes() { | ||
| return mNoTaskIconRes; | ||
| } |
There was a problem hiding this comment.
@JoseAlcerreca Is it really needed to expose these objects as Mutable LiveData?
There was a problem hiding this comment.
No, they should be MutableLiveDatas only in the ViewModel, exposed as LiveDatas. That's a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing resolved resources from ViewModels is not a good idea because they survive configuration changes, including locale changes. See #574 and https://issuetracker.google.com/issues/111961971
In this PR we leverage Data Binding to load those resources for us with the nice side-effect of removing the need for AndroidViewModels so no context is available in them. (I'm considering moving AndroidViewModels to the smell category.)