remote, #519: FIX1-of-2 double-decoding push-infos

+ When `universal_lines==True` (515a6b9) must tel
`handle_process_output` to stop decoding strings.

Author: ankostis

git/remote.py

@@ -681,7 +681,8 @@ def stdout_handler(line):
         # END for each line
 
         try:
-            handle_process_output(proc, stdout_handler, progress_handler, finalize_process)
+            handle_process_output(proc, stdout_handler, progress_handler, finalize_process,
+                                  decode_stdout=False, decode_stderr=False)
         except Exception:
             if len(output) == 0:
                 raise

git/test/lib/helper.py

@@ -258,8 +258,10 @@ def remote_repo_creator(self):
                     # We assume in good faith that we didn't start the daemon - but make sure we kill it anyway
                     # Of course we expect it to work here already, but maybe there are timing constraints
                     # on some platforms ?
-                    if gd is not None:
+                    try:
                         gd.proc.terminate()
+                    except Exception as ex:
+                        log.debug("Ignoring %r while terminating proc after %r.", ex, e)
                     log.warning('git(%s) ls-remote failed due to:%s',
                                 rw_repo.git_dir, e)
                     if is_win:
@@ -296,8 +298,10 @@ def remote_repo_creator(self):
                     os.chdir(prev_cwd)
 
             finally:
-                if gd is not None:
+                try:
                     gd.proc.kill()
+                except:
+                    pass ## Either it has died (and we're here), or it won't die, again here...
 
                 rw_repo.git.clear_cache()
                 rw_remote_repo.git.clear_cache()

git/util.py

@@ -3,6 +3,7 @@
 #
 # This module is part of GitPython and is released under
 # the BSD License: http://www.opensource.org/licenses/bsd-license.php
+from __future__ import unicode_literals
 
 import os
 import re