Skip to content

Commit e7fa5ef

Browse files
committed
added test & fix for mangled tagger names
1 parent a98e0af commit e7fa5ef

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

‎git/objects/tag.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def _set_cache_(self, attr):
5858

5959
self.tag = lines[2][4:] # tag <tag name>
6060

61-
tagger_info = lines[3][7:]# tagger <actor> <date>
61+
tagger_info = lines[3]# tagger <actor> <date>
6262
self.tagger, self.tagged_date, self.tagger_tz_offset = parse_actor_and_date(tagger_info)
6363

6464
# line 4 empty - it could mark the beginning of the next header

‎git/test/test_refs.py

+10
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,16 @@ def test_tag_base(self):
4949
# END for tag in repo-tags
5050
assert tag_object_refs
5151
assert isinstance(self.rorepo.tags['0.1.5'], TagReference)
52+
53+
54+
def test_tags_author(self):
55+
tag = self.rorepo.tags[0]
56+
tagobj = tag.tag
57+
assert isinstance( tagobj.tagger, Actor )
58+
tagger_name = tagobj.tagger.name
59+
assert tagger_name == 'Michael Trier'
60+
61+
5262

5363
def test_tags(self):
5464
# tag refs can point to tag objects or to commits

0 commit comments

Comments
 (0)