Skip to content

Commit 8df3dd9

Browse files
committed
fix(remote): improve version check
Make version check much more readable, and fix it at the same time. The previous implementation would assume progress is supported just by looking at the patch-level for instance. A quick check of the git sources seems to indicate the --progress flag exists in v1.7 of the git command-line already. Fixes #449
1 parent 2972481 commit 8df3dd9

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

‎git/remote.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ def add_progress(kwargs, git, progress):
5050
given, we do not request any progress
5151
:return: possibly altered kwargs"""
5252
if progress is not None:
53-
v = git.version_info
54-
if v[0] > 1 or v[1] > 7 or v[2] > 0 or v[3] > 3:
53+
v = git.version_info[:2]
54+
if v >= (1, 7):
5555
kwargs['progress'] = True
5656
# END handle --progress
5757
# END handle progress

0 commit comments

Comments
 (0)