Skip to content

Commit 4bcc4d5

Browse files
committed
Deprecate Diffable.rename for .renamed_file
Fixes #426
1 parent fb577c8 commit 4bcc4d5

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

‎git/diff.py

+10-1
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,16 @@ def __str__(self):
333333

334334
@property
335335
def renamed(self):
336-
""":returns: True if the blob of our diff has been renamed"""
336+
""":returns: True if the blob of our diff has been renamed
337+
:note: This property is deprecated, please use ``renamed_file`` instead.
338+
"""
339+
return self.renamed_file
340+
341+
@property
342+
def renamed_file(self):
343+
""":returns: True if the blob of our diff has been renamed
344+
:note: This property is deprecated, please use ``renamed_file`` instead.
345+
"""
337346
return self.rename_from != self.rename_to
338347

339348
@classmethod

‎git/test/test_diff.py

+2
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ def test_diff_with_rename(self):
8686
assert_equal(1, len(diffs))
8787

8888
diff = diffs[0]
89+
assert_true(diff.renamed_file)
8990
assert_true(diff.renamed)
9091
assert_equal(diff.rename_from, u'Jérôme')
9192
assert_equal(diff.rename_to, u'müller')
@@ -95,6 +96,7 @@ def test_diff_with_rename(self):
9596
diffs = Diff._index_from_raw_format(self.rorepo, output.stdout)
9697
assert len(diffs) == 1
9798
diff = diffs[0]
99+
assert diff.renamed_file
98100
assert diff.renamed
99101
assert diff.rename_from == 'this'
100102
assert diff.rename_to == 'that'

0 commit comments

Comments
 (0)