Skip to content

Commit a6644eb

Browse files
authored
Align overwriting of get_queryset in example app and documentation (#979)
Fixes #487
1 parent f8209c0 commit a6644eb

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

‎docs/usage.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -620,14 +620,14 @@ class LineItemViewSet(viewsets.ModelViewSet):
620620
serializer_class = LineItemSerializer
621621

622622
def get_queryset(self):
623-
queryset = super(LineItemViewSet, self).get_queryset()
623+
queryset = super().get_queryset()
624624

625625
# if this viewset is accessed via the 'order-lineitems-list' route,
626626
# it wll have been passed the `order_pk` kwarg and the queryset
627627
# needs to be filtered accordingly; if it was accessed via the
628628
# unnested '/lineitems' route, the queryset should include all LineItems
629-
if 'order_pk' in self.kwargs:
630-
order_pk = self.kwargs['order_pk']
629+
order_pk = self.kwargs.get('order_pk')
630+
if order_pk is not None:
631631
queryset = queryset.filter(order__pk=order_pk)
632632

633633
return queryset

‎example/views.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -243,11 +243,13 @@ class CommentViewSet(ModelViewSet):
243243
}
244244

245245
def get_queryset(self, *args, **kwargs):
246+
queryset = super().get_queryset()
247+
246248
entry_pk = self.kwargs.get("entry_pk", None)
247249
if entry_pk is not None:
248-
return self.queryset.filter(entry_id=entry_pk)
250+
queryset = queryset.filter(entry_id=entry_pk)
249251

250-
return super(CommentViewSet, self).get_queryset()
252+
return queryset
251253

252254

253255
class CompanyViewset(ModelViewSet):

0 commit comments

Comments
 (0)