Skip to content

Commit 7a8f96c

Browse files
committed
fix(cmd): don't catch progress handler exceptions
Fixes gitpython-developers#435
1 parent db44286 commit 7a8f96c

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

‎doc/source/changes.rst

+6
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22
Changelog
33
=========
44

5+
2.0.3 - Fixes
6+
=============
7+
8+
* Fix: progress handler exceptions are not caught anymore, which would usually just hide bugs
9+
previously.
10+
511
2.0.2 - Fixes
612
=============
713

‎git/cmd.py

+1-6
Original file line numberDiff line numberDiff line change
@@ -113,12 +113,7 @@ def _read_lines_from_fno(fno, last_buf_list):
113113
def _dispatch_single_line(line, handler):
114114
line = line.decode(defenc)
115115
if line and handler:
116-
try:
117-
handler(line)
118-
except Exception:
119-
# Keep reading, have to pump the lines empty nontheless
120-
log.error("Line handler exception on line: %s", line, exc_info=True)
121-
# end
116+
handler(line)
122117
# end dispatch helper
123118
# end single line helper
124119

0 commit comments

Comments
 (0)