Skip to content

Commit dd8a563

Browse files
committed
Enable build-id for shared library
1 parent 7c12ac1 commit dd8a563

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

‎README.md

-1
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ In future build reproduction might become easier. Here's a list of related PR-we
8888

8989
* Project path must not affect the resulting `.so` files, so user & project location requirement could be removed
9090
* When building native binaries on **macOS**, `.comment` ELF section differs from the one built with **Linux** version of NDK. It must be removed or made deterministic without any side-effects like breaking `native-debug-symbols.zip` (or should be reported to NDK team?)
91-
* It might be a good idea to use `--build-id=0x<commit>` instead of `--build-id=none`
9291
* Checksums of cold APK builds always differ, even though the same keystore applied and generated inner APK contents do not differ. Real cause must be investigated and fixed, if possible.<br/>To generate cold build, invoke `$ scripts/./reset.sh` and `$ scripts/./setup.sh --skip-sdk-setup`.<br/>**Warning**: this will also reset changes inside some of the submodules ([ffmpeg](/app/jni/thirdparty/ffmpeg), [libvpx](/app/jni/thirdparty/libvpx), [webp](/app/jni/thirdparty/webp), [opus](/app/jni/thirdparty/opus) and [ExoPlayer](/app/jni/thirdparty/exoplayer))
9392
* Move local pull requests squash-merging from [Publisher](https://github.com/TGX-Android/Publisher) to some script inside this repository to make reproduction of builds that include them easier.
9493

‎app/jni/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ endforeach()
9191

9292
set(ADD_LINKER_FLAGS
9393
-Wl,--gc-sections,--icf=safe
94-
-Wl,--build-id=none
94+
-Wl,--build-id=sha1
9595
)
9696
set(EXCLUDE_LIBS
9797
libjni-utils.a

0 commit comments

Comments
 (0)