Add sanity check for dshash entries when reading pgstats file
authorMichael Paquier <michael@paquier.xyz>
Thu, 24 Apr 2025 00:20:01 +0000 (09:20 +0900)
committerMichael Paquier <michael@paquier.xyz>
Thu, 24 Apr 2025 00:20:01 +0000 (09:20 +0900)
Not having this check would produce a core dump at startup when running
pgstat_read_statsfile(), in the case where the information of a stats
kind for an entry in the dshash could not be found.  The same check
already happens for fixed-numbered stats and entries that are stored
with their names.  This issue can be seen with custom stats kinds.

Note that this problem can be reproduced what what is in the core code:
- Tweak the test module injection_points to not load the fixed-numbered
stats part, leaving only the variable-numbered stats.
- Create an instance with injection_points defined in
shared_preload_libraries.
- Create a pgstats entry by attaching and running a point.
- Restart the server without shared_preload_libraries.  The startup
process detects that something is wrong and reports a WARNING.

Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://postgr.es/m/aAieZAvM+K1d89R2@ip-10-97-1-34.eu-west-3.compute.internal

src/backend/utils/activity/pgstat.c

index 17a910b8857842f3f2e9c7b7d52abe1faafbcc00..a428b079c2e56223f6c3613aa8b27ed0628d2609 100644 (file)
@@ -1905,6 +1905,14 @@ pgstat_read_statsfile(void)
                                 key.objid, t);
                            goto error;
                        }
+
+                       if (!pgstat_get_kind_info(key.kind))
+                       {
+                           elog(WARNING, "could not find information of kind for entry %u/%u/%" PRIu64 " of type %c",
+                                key.kind, key.dboid,
+                                key.objid, t);
+                           goto error;
+                       }
                    }
                    else
                    {