All Questions
Tagged with source-code code-reviews
11 questions
-1
votes
1
answer
1k
views
What is the meaning of 'code vetting' in Software Engineering? [closed]
I saw the term code vetting for the first time in a gerrit review page. What does it mean?
The line I came across:
"No XYZ check was done. However, if this project is intended to be
shipped in ...
- 123
-1
votes
1
answer
179
views
Should one create code review for an incomplete unfinished change? [duplicate]
Had this happened:
A developer make a new feature, but not working, since last year, total code change is 100+files and 10k lines.
Until recently, with help of another developer, get it to work.
...
- 193
6
votes
5
answers
1k
views
Check if variable is not null before setting to null
One of our team likes to write code like this (C#):
if (_someVar != null)
{
_someVar = null;
}
Rather than simply:
_someVar = null;
I've never used the former as I always assumed it was ...
- 1,135
1
vote
3
answers
275
views
What is the most readable way of passing arguments to the function? [closed]
I'm using JavaScript but the question can be generalized to all the languages.
In a nutshell - I'm checking if a browser connecting to my site is a microwave and cater for that accordingly.
What ...
- 175
52
votes
9
answers
11k
views
Bad sign if nobody can comprehend one's code? [duplicate]
If a coder writes code that nobody other than he can understand, and code reviews always end with the reviewer scratching his head or holding their head in their hands, is this a clear sign that the ...
- 727
20
votes
9
answers
3k
views
What exactly makes code "clean"? [duplicate]
I am an intern at a small software company, doing typical grunt work. Many tasks that the actual developers are doing are above my head however I finally got to see some real "action" and write some ...
- 502
9
votes
2
answers
434
views
What tools or techniques are useful for describing an unfamiliar codebase? [closed]
When manually inspecting unfamiliar code (to review or modify), I seem to have three options.
A top-down read of the code, choosing each next source file by how fundamental the filename seems. I ...
- 327
8
votes
3
answers
1k
views
Does studying other people's programs help in self growth? [closed]
Should I be studying big softwares written by other people in our company? My work may be a small sub module on the top of that software, and I may not be required to know what goes beneath the hood, ...
- 1,611
9
votes
3
answers
2k
views
Are there code reviews in opensource projects? If so, what tools are used to do this?
I know there is a big push for code reviews in commercial development. However, are code reviews used in open source software or is based on trust? If so, then how are they performed? [Is it a delayed ...
- 639
5
votes
2
answers
597
views
Are there any opensource APIs that help analyze code?
As an example, let's say that I need to check for a certain usage of C# code and warn the user that that is a bad pratice. There are multiple usages that I want to detect, such as:
Resource not being ...
- 371
3
votes
4
answers
4k
views
source code check in / validation best practices
I am looking for best practices that big organizations follow for code check-in and validations.
Currently we follow these steps,
- Developer writes code
- Developer do some initial tests
- Code is ...
- 31