feat(@angular/cli): drop support for Node.js 12

Node.js v12 will become EOL on 2022-04-30. As a result, Angular CLI v14 will no longer support Node.js v12.

BREAKING CHANGE:

Support for Node.js v12 has been removed as it will become EOL on 2022-04-30. Please use Node.js v14.15 or later.

Author: alan-agius4

constants.bzl

@@ -1,5 +1,5 @@
 # Engine versions to stamp in a release package.json
-RELEASE_ENGINES_NODE = "^12.20.0 || ^14.15.0 || >=16.10.0"
+RELEASE_ENGINES_NODE = "^14.15.0 || >=16.10.0"
 RELEASE_ENGINES_NPM = "^6.11.0 || ^7.5.6 || >=8.0.0"
 RELEASE_ENGINES_YARN = ">= 1.13.0"
 

docs/DEVELOPER.md

@@ -6,7 +6,7 @@ To get started locally, follow these instructions:
 
 1. If you haven't done it already, [make a fork of this repo](https://github.com/angular/angular-cli/fork).
 1. Clone to your local computer using `git`.
-1. Make sure that you have Node `v12.20`, `v14.15`, or `v16.10` installed. See instructions [here](https://nodejs.org/en/download/).
+1. Make sure that you have Node `v14.15`, or `v16.10` installed. See instructions [here](https://nodejs.org/en/download/).
 1. Make sure that you have `yarn` installed; see instructions [here](https://yarnpkg.com/lang/en/docs/install/).
 1. Run `yarn` (no arguments) from the root of your clone of this project to install dependencies.
 

lib/packages.ts

@@ -85,7 +85,7 @@ function loadPackageJson(p: string) {
       // Overwrite engines to a common default.
       case 'engines':
         pkg['engines'] = {
-          'node': '^12.20.0 || ^14.15.0 || >=16.10.0',
+          'node': '^14.15.0 || >=16.10.0',
           'npm': '^6.11.0 || ^7.5.6 || >=8.0.0',
           'yarn': '>= 1.13.0',
         };

package.json

@@ -40,7 +40,7 @@
     "url": "https://github.com/angular/angular-cli.git"
   },
   "engines": {
-    "node": "^12.20.0 || ^14.15.0 || ^16.10.0",
+    "node": "^14.15.0 || ^16.10.0",
     "yarn": ">=1.21.1 <2",
     "npm": "Please use yarn instead of NPM to install dependencies"
   },
@@ -104,7 +104,7 @@
     "@types/karma": "^6.3.0",
     "@types/loader-utils": "^2.0.0",
     "@types/minimatch": "3.0.5",
-    "@types/node": "~12.12.6",
+    "@types/node": "^14.15.0",
     "@types/node-fetch": "^2.1.6",
     "@types/npm-package-arg": "^6.1.0",
     "@types/parse5-html-rewriting-stream": "^5.1.2",

packages/angular/cli/bin/ng.js

@@ -36,19 +36,17 @@ if (version[0] % 2 === 1 && version[0] > 16) {
 
   require('./bootstrap');
 } else if (
-  version[0] < 12 ||
-  version[0] === 13 ||
+  version[0] < 14 ||
   version[0] === 15 ||
-  (version[0] === 12 && version[1] < 20) ||
   (version[0] === 14 && version[1] < 15) ||
   (version[0] === 16 && version[1] < 10)
 ) {
-  // Error and exit if less than 12.20 or 13.x or less than 14.15 or 15.x or less than 16.10
+  // Error and exit if less than 14.15 or 15.x or less than 16.10
   console.error(
     'Node.js version ' +
       process.version +
       ' detected.\n' +
-      'The Angular CLI requires a minimum Node.js version of either v12.20, v14.15, or v16.10.\n\n' +
+      'The Angular CLI requires a minimum Node.js version of either v14.15, or v16.10.\n\n' +
       'Please update your Node.js version or visit https://nodejs.org/ for additional instructions.\n',
   );
 

packages/angular/cli/commands/update-impl.ts

@@ -635,32 +635,11 @@ export class UpdateCommand extends Command<UpdateCommandSchema> {
       try {
         // Remove existing node modules directory to provide a stronger guarantee that packages
         // will be hoisted into the correct locations.
-
-        // The below should be removed and replaced with just `rm` when support for Node.Js 12 is removed.
-        const { rm, rmdir } = fs.promises as typeof fs.promises & {
-          rm?: (
-            path: fs.PathLike,
-            options?: {
-              force?: boolean;
-              maxRetries?: number;
-              recursive?: boolean;
-              retryDelay?: number;
-            },
-          ) => Promise<void>;
-        };
-
-        if (rm) {
-          await rm(path.join(this.context.root, 'node_modules'), {
-            force: true,
-            recursive: true,
-            maxRetries: 3,
-          });
-        } else {
-          await rmdir(path.join(this.context.root, 'node_modules'), {
-            recursive: true,
-            maxRetries: 3,
-          });
-        }
+        await fs.promises.rm(path.join(this.context.root, 'node_modules'), {
+          force: true,
+          recursive: true,
+          maxRetries: 3,
+        });
       } catch {}
 
       const result = await installAllPackages(

packages/angular/cli/lib/cli/index.ts

@@ -22,11 +22,11 @@ const isDebug = debugEnv !== undefined && debugEnv !== '0' && debugEnv.toLowerCa
 /* eslint-disable no-console */
 export default async function (options: { testing?: boolean; cliArgs: string[] }) {
   // This node version check ensures that the requirements of the project instance of the CLI are met
-  const version = process.versions.node.split('.').map((part) => Number(part));
-  if (version[0] < 12 || (version[0] === 12 && version[1] < 20)) {
+  const [major, minor] = process.versions.node.split('.').map((part) => Number(part));
+  if (major < 14 || (major === 14 && minor < 15)) {
     process.stderr.write(
       `Node.js version ${process.version} detected.\n` +
-        'The Angular CLI requires a minimum v12.20.\n\n' +
+        'The Angular CLI requires a minimum v14.15.\n\n' +
         'Please update your Node.js version or visit https://nodejs.org/ for additional instructions.\n',
     );
 

packages/angular_devkit/build_angular/src/utils/delete-output-dir.ts

@@ -18,22 +18,5 @@ export function deleteOutputDir(root: string, outputPath: string): void {
     throw new Error('Output path MUST not be project root directory!');
   }
 
-  // The below should be removed and replace with just `rmSync` when support for Node.Js 12 is removed.
-  const { rmSync, rmdirSync } = fs as typeof fs & {
-    rmSync?: (
-      path: fs.PathLike,
-      options?: {
-        force?: boolean;
-        maxRetries?: number;
-        recursive?: boolean;
-        retryDelay?: number;
-      },
-    ) => void;
-  };
-
-  if (rmSync) {
-    rmSync(resolvedOutputPath, { force: true, recursive: true, maxRetries: 3 });
-  } else {
-    rmdirSync(resolvedOutputPath, { recursive: true, maxRetries: 3 });
-  }
+  fs.rmSync(resolvedOutputPath, { force: true, recursive: true, maxRetries: 3 });
 }

packages/angular_devkit/build_angular/src/utils/i18n-options.ts

@@ -279,25 +279,8 @@ function findLocaleDataPath(locale: string, resolver: (locale: string) => string
 
 /** Remove temporary directory used for i18n processing. */
 function deleteTempDirectory(tempPath: string): void {
-  // The below should be removed and replaced with just `rmSync` when support for Node.Js 12 is removed.
-  const { rmSync, rmdirSync } = fs as typeof fs & {
-    rmSync?: (
-      path: fs.PathLike,
-      options?: {
-        force?: boolean;
-        maxRetries?: number;
-        recursive?: boolean;
-        retryDelay?: number;
-      },
-    ) => void;
-  };
-
   try {
-    if (rmSync) {
-      rmSync(tempPath, { force: true, recursive: true, maxRetries: 3 });
-    } else {
-      rmdirSync(tempPath, { recursive: true, maxRetries: 3 });
-    }
+    fs.rmSync(tempPath, { force: true, recursive: true, maxRetries: 3 });
   } catch {}
 }
 

packages/angular_devkit/build_angular/src/utils/purge-cache.ts

@@ -25,27 +25,12 @@ export async function purgeStaleBuildCache(context: BuilderContext): Promise<voi
     return;
   }
 
-  // The below should be removed and replaced with just `rm` when support for Node.Js 12 is removed.
-  const { rm, rmdir } = fsPromises as typeof fsPromises & {
-    rm?: (
-      path: PathLike,
-      options?: {
-        force?: boolean;
-        maxRetries?: number;
-        recursive?: boolean;
-        retryDelay?: number;
-      },
-    ) => Promise<void>;
-  };
-
   const entriesToDelete = (await fsPromises.readdir(basePath, { withFileTypes: true }))
     .filter((d) => join(basePath, d.name) !== path && d.isDirectory())
     .map((d) => {
       const subPath = join(basePath, d.name);
       try {
-        return rm
-          ? rm(subPath, { force: true, recursive: true, maxRetries: 3 })
-          : rmdir(subPath, { recursive: true, maxRetries: 3 });
+        return fsPromises.rm(subPath, { force: true, recursive: true, maxRetries: 3 });
       } catch {}
     });
 

packages/angular_devkit/core/node/host.ts

@@ -18,22 +18,12 @@ import fs, {
   readdirSync,
   renameSync,
   statSync,
-  unlinkSync,
   writeFileSync,
 } from 'fs';
 import { dirname as pathDirname } from 'path';
-import { Observable, concat, from as observableFrom, of, throwError } from 'rxjs';
-import { concatMap, map, mergeMap, publish, refCount } from 'rxjs/operators';
-import {
-  Path,
-  PathFragment,
-  dirname,
-  fragment,
-  getSystemPath,
-  join,
-  normalize,
-  virtualFs,
-} from '../src';
+import { Observable, from as observableFrom } from 'rxjs';
+import { map, mergeMap, publish, refCount } from 'rxjs/operators';
+import { Path, PathFragment, dirname, fragment, getSystemPath, normalize, virtualFs } from '../src';
 
 async function exists(path: PathLike): Promise<boolean> {
   try {
@@ -88,31 +78,8 @@ export class NodeJsAsyncHost implements virtualFs.Host<Stats> {
   }
 
   delete(path: Path): Observable<void> {
-    return this.isDirectory(path).pipe(
-      mergeMap(async (isDirectory) => {
-        if (isDirectory) {
-          // The below should be removed and replaced with just `rm` when support for Node.Js 12 is removed.
-          const { rm, rmdir } = fsPromises as typeof fsPromises & {
-            rm?: (
-              path: fs.PathLike,
-              options?: {
-                force?: boolean;
-                maxRetries?: number;
-                recursive?: boolean;
-                retryDelay?: number;
-              },
-            ) => Promise<void>;
-          };
-
-          if (rm) {
-            await rm(getSystemPath(path), { force: true, recursive: true, maxRetries: 3 });
-          } else {
-            await rmdir(getSystemPath(path), { recursive: true, maxRetries: 3 });
-          }
-        } else {
-          await fsPromises.unlink(getSystemPath(path));
-        }
-      }),
+    return observableFrom(
+      fsPromises.rm(getSystemPath(path), { force: true, recursive: true, maxRetries: 3 }),
     );
   }
 
@@ -208,45 +175,11 @@ export class NodeJsSyncHost implements virtualFs.Host<Stats> {
   }
 
   delete(path: Path): Observable<void> {
-    return this.isDirectory(path).pipe(
-      concatMap((isDir) => {
-        if (isDir) {
-          const dirPaths = readdirSync(getSystemPath(path));
-          const rmDirComplete = new Observable<void>((obs) => {
-            // The below should be removed and replaced with just `rmSync` when support for Node.Js 12 is removed.
-            const { rmSync, rmdirSync } = fs as typeof fs & {
-              rmSync?: (
-                path: fs.PathLike,
-                options?: {
-                  force?: boolean;
-                  maxRetries?: number;
-                  recursive?: boolean;
-                  retryDelay?: number;
-                },
-              ) => void;
-            };
-
-            if (rmSync) {
-              rmSync(getSystemPath(path), { force: true, recursive: true, maxRetries: 3 });
-            } else {
-              rmdirSync(getSystemPath(path), { recursive: true, maxRetries: 3 });
-            }
-
-            obs.complete();
-          });
+    return new Observable<void>((obs) => {
+      fs.rmSync(getSystemPath(path), { force: true, recursive: true, maxRetries: 3 });
 
-          return concat(...dirPaths.map((name) => this.delete(join(path, name))), rmDirComplete);
-        } else {
-          try {
-            unlinkSync(getSystemPath(path));
-          } catch (err) {
-            return throwError(err);
-          }
-
-          return of(undefined);
-        }
-      }),
-    );
+      obs.complete();
+    });
   }
 
   rename(from: Path, to: Path): Observable<void> {

scripts/build-bazel.ts

@@ -50,24 +50,7 @@ function _recursiveCopy(from: string, to: string, logger: logging.Logger) {
 }
 
 function rimraf(location: string) {
-  // The below should be removed and replace with just `rmSync` when support for Node.Js 12 is removed.
-  const { rmSync, rmdirSync } = fs as typeof fs & {
-    rmSync?: (
-      path: fs.PathLike,
-      options?: {
-        force?: boolean;
-        maxRetries?: number;
-        recursive?: boolean;
-        retryDelay?: number;
-      },
-    ) => void;
-  };
-
-  if (rmSync) {
-    rmSync(location, { force: true, recursive: true, maxRetries: 3 });
-  } else {
-    rmdirSync(location, { recursive: true, maxRetries: 3 });
-  }
+  fs.rmSync(location, { force: true, recursive: true, maxRetries: 3 });
 }
 
 function _clean(logger: logging.Logger) {

scripts/build-schema.ts

@@ -19,25 +19,7 @@ export default async function (argv: {}, logger: logging.Logger) {
 
   const quicktypeRunner = require('../tools/quicktype_runner');
   logger.info('Removing dist-schema/...');
-
-  // The below should be removed and replace with just `rmSync` when support for Node.Js 12 is removed.
-  const { rmSync, rmdirSync } = fs as typeof fs & {
-    rmSync?: (
-      path: fs.PathLike,
-      options?: {
-        force?: boolean;
-        maxRetries?: number;
-        recursive?: boolean;
-        retryDelay?: number;
-      },
-    ) => void;
-  };
-
-  if (rmSync) {
-    rmSync(dist, { force: true, recursive: true, maxRetries: 3 });
-  } else {
-    rmdirSync(dist, { recursive: true, maxRetries: 3 });
-  }
+  fs.rmSync(dist, { force: true, recursive: true, maxRetries: 3 });
 
   logger.info('Generating JSON Schema....');
 

scripts/build.ts

@@ -122,24 +122,7 @@ function _rm(p: string) {
 }
 
 function rimraf(location: string) {
-  // The below should be removed and replace with just `rmSync` when support for Node.Js 12 is removed.
-  const { rmSync, rmdirSync } = fs as typeof fs & {
-    rmSync?: (
-      path: fs.PathLike,
-      options?: {
-        force?: boolean;
-        maxRetries?: number;
-        recursive?: boolean;
-        retryDelay?: number;
-      },
-    ) => void;
-  };
-
-  if (rmSync) {
-    rmSync(location, { force: true, recursive: true, maxRetries: 3 });
-  } else {
-    rmdirSync(location, { recursive: true, maxRetries: 3 });
-  }
+  fs.rmSync(location, { force: true, recursive: true, maxRetries: 3 });
 }
 
 function _clean(logger: logging.Logger) {