Sloane Bernstein [Tue, 16 Feb 2021 22:19:09 +0000 (16:19 -0600)]
Restore support for PgSQL 9.4 and below
The addition of support for PostgreSQL 9.6 and above neglected to change the `Postgres94` class to inherit from `Postgres95` instead of the latest `Postgres` class. This change restores the chain of inheritance, so that `Postgres94` and classes below see overridden methods from `Postgres95` and above.
nirgal [Mon, 9 Nov 2020 19:12:34 +0000 (19:12 +0000)]
Fix national-encoding in CREDITS
There was a non-UTF8 character in Marek Černocký last name. Moreover, he was already listed.
Robert Treat [Mon, 9 Nov 2020 04:35:57 +0000 (23:35 -0500)]
Fix typo
Robert Treat [Sat, 7 Nov 2020 06:09:12 +0000 (01:09 -0500)]
Update credits and history for 7.13.0 release
Robert Treat [Sat, 7 Nov 2020 05:35:14 +0000 (00:35 -0500)]
Bump min php ver to 7.2, set app ver to 7.13.0 for release
Robert Treat [Wed, 28 Oct 2020 05:18:52 +0000 (01:18 -0400)]
Consider group membership when testing owned_only
Based on code and suggestions from @cathysax, ultimately I used the internal
pg_has_role function to test whether a user has ownership rights based on
group membership. I actually check for 'USAGE' rights, since that implies the
role has rights without need to `set role`, which users wouldn't be able to do
with a normal PPA login. Loosely tested back to 9.5.
This fixes https://github.com/phppgadmin/phppgadmin/issues/102
Robert Treat [Thu, 8 Oct 2020 05:39:43 +0000 (01:39 -0400)]
Fix links to docs for pgsql 13 & 14
For version 14, we point to the /devel/ docs, since that version is currently
in dev. I also bumped the fall through to point to v14, arguably we could
instead point to /current/, but any current version will work, so I think
devel is more likely.
Viktor Vakhonin [Thu, 8 Oct 2020 14:27:57 +0000 (17:27 +0300)]
Remove php5 from tests
Robert Treat [Wed, 7 Oct 2020 04:30:51 +0000 (00:30 -0400)]
Clean up pass by ref warnings in constraints tab
MichaMEG [Thu, 1 Oct 2015 09:38:40 +0000 (11:38 +0200)]
sorting goes to table names (through select)
Jean-Michel Vourgère [Mon, 23 Dec 2019 14:23:12 +0000 (15:23 +0100)]
Adjustements for jquery update
- Replaced .click(function) by .on('click', function)
- Replaced .click() by .trigger('click')
- Replaced .live(event, function) by .on(event, function)
- Replaced $(document).ready(function) by $(function)
- Replaced .bind/.unbind by .on/.off
- Replaced keypress events by keydown events, so that up/down keys get
supported again.
Thanks to the jquery-migrate project.
Jean-Michel Vourgère [Sun, 20 Oct 2019 21:14:21 +0000 (23:14 +0200)]
Upgraded jquery to version 3.4.1
Note that the minimized version is not considered "source code".
nirgal [Sun, 15 Dec 2019 07:50:03 +0000 (07:50 +0000)]
Drop obsolete export-ignore
.build_tests.php no longer exists: There is no need to exclude it.
Robert Treat [Mon, 5 Oct 2020 04:30:05 +0000 (00:30 -0400)]
Add support for Postgres 13,14dev
Robert Treat [Mon, 9 Dec 2019 06:45:24 +0000 (01:45 -0500)]
Update HISTORY and Bump version for 7.12.1
Robert Treat [Sun, 8 Dec 2019 02:39:12 +0000 (21:39 -0500)]
Clean up OID handling changes
This is mostly just refactoring Nirgals patch to use a standard
capability function. I also short-circuited default_with_oid check since it
will always show false in >=PG12, so this saves a round trip. This also adds
a comment in the config file that show oids is no longer supported. This
could lead to a slight difference in running instalations, but since it
does not affect any code/behavior, not going to bump the config version.
Jean-Michel Vourgère [Wed, 6 Nov 2019 17:01:27 +0000 (18:01 +0100)]
Disable OID handling on PG12
Notes:
- "CREATE TABLE WITHOUT OIDS" continues to work, for now
- "SHOW default_with_oids" continues to work, for now
soleuu [Thu, 24 Oct 2019 15:00:14 +0000 (15:00 +0000)]
privilege - missing USAGE on sequence
nirgal [Wed, 6 Nov 2019 11:34:43 +0000 (11:34 +0000)]
Drop PHP safe mode howto
Safe mode disappeared with php 5.4 (September 2015), and version 7.1 or above is required.
https://www.php.net/manual/en/features.safe-mode.php
Jean-Michel Vourgère [Thu, 7 Nov 2019 09:10:07 +0000 (10:10 +0100)]
codespell assisted typo cleaning
Jean-Michel Vourgère [Sun, 20 Oct 2019 12:03:56 +0000 (14:03 +0200)]
Refreshed French translation
Robert Treat [Thu, 31 Oct 2019 20:49:02 +0000 (21:49 +0100)]
Grammer fixes noticed during spelling fixes review
Jean-Michel Vourgère [Sun, 20 Oct 2019 20:47:32 +0000 (22:47 +0200)]
codespell assisted typo cleaning
Robert Treat [Mon, 21 Oct 2019 00:04:28 +0000 (20:04 -0400)]
Update HISTORY w/ related multibyte string changes
Jean-Michel Vourgère [Sun, 20 Oct 2019 10:42:24 +0000 (12:42 +0200)]
Print an error if mbstring extension is missing
Generic missing extension messages
Jean-Michel Vourgère [Sat, 5 Oct 2019 14:43:54 +0000 (16:43 +0200)]
Added php-mbstring dependency in composer
nirgal [Fri, 4 Oct 2019 08:58:02 +0000 (08:58 +0000)]
Support truncation of mulitbyte srings
This fixes https://sourceforge.net/p/phppgadmin/bugs/422/ :
substr truncates on a byte-level, sometimes within a multi-byte character. This resulted in the whole string sometime not being displayed. See the original bug report for a way to reproduce.
Please note that this requires php-mbstring to be installed. This is usually the case, but the dependency should be described in the INSTALL file or something.
Robert Treat [Sat, 12 Oct 2019 22:55:13 +0000 (18:55 -0400)]
Update HISTORY wrt escaping schema/tables/view identifiers
soleuu [Fri, 27 Sep 2019 15:11:36 +0000 (15:11 +0000)]
escape schema/table/view identifier
Robert Treat [Sat, 12 Oct 2019 22:39:50 +0000 (18:39 -0400)]
Bump copyright dates for phppgadmin project.
Robert Treat [Sat, 12 Oct 2019 22:37:53 +0000 (18:37 -0400)]
Bump minimum version of PHP required.
Add php-pgsql as a dependency.
This resolves issue #71
Robert Treat [Sat, 12 Oct 2019 19:23:16 +0000 (15:23 -0400)]
Add bugfix to history file
nirgal [Tue, 8 Oct 2019 15:42:12 +0000 (15:42 +0000)]
xtree: tables & views can't expand the browse item
In the left tree, in tables and views, when one click on the + of browse, a message like "Erreur lors du chargement display.php?action=tree&return=schema&subject=view&view=test+vue&server=localhost%3A5432%3Aallow&database=bug422&schema=public (200: OK)" is displayed.
These items don't support tree actions, and the tree expansion should be be offered in the first place.
Robert Treat [Sat, 28 Sep 2019 21:05:30 +0000 (17:05 -0400)]
Mark PPA release 7.12.0
Update HISTORY and clean up CREDITS file for new release.
Robert Treat [Sat, 28 Sep 2019 20:56:26 +0000 (16:56 -0400)]
Bump minimum supported PHP version to 7.1
qingfeng [Tue, 6 Aug 2019 02:40:31 +0000 (10:40 +0800)]
correct files of chinese translations
Robert Treat [Tue, 24 Sep 2019 21:05:24 +0000 (17:05 -0400)]
Overhaul sequence properties page to better handle different permissions.
Whilst fixing the sequence group viewing bug, noticed that sequence properties
in general would throw an error if you did not have appropriate permissions.
While this is similar to permission denied errors when looking directly at
a sequence, there is other information to be exposed which is accesible
through pg_sequence and pg_sequences. The change implements a method for
determining if a user can access the sequence directly (ie. select * from seq)
and if so, include that information in the output. If not, we null those
columns.
This also fixes cases where last_value information is not visible due to a
sequence not haveing been "read" yet. ie. after sequence creation, or anytime
a sequence is altered, and nextval/setval hasn't been called.
This problem seems to go back to at least postgres 9, so I've mainlined the fix.
It might break on older unsupported versions of postgres; if someone wants to
fix that well... patches welcome.
Robert Treat [Sun, 22 Sep 2019 04:42:48 +0000 (00:42 -0400)]
Fix for SF BUG #470 Can't list/see/edit sequences owned by group
While I have implemented this fix against Postgres 12, as far as I can tell,
this bug existed since 7.x, so I'm adding it to all versions back to 7.4
(when we did the class re-org). This could probably use more testing on older
versions though.
Thanks to Carlos Martinez for the bug report and reproducible test case!
zhcj [Sat, 27 Jul 2019 15:17:38 +0000 (23:17 +0800)]
chinese translation error
translation error
Ömer Çıtak [Fri, 2 Sep 2016 10:26:37 +0000 (13:26 +0300)]
fixed Reflected XSS vulnerability
"table" and "schema" parameters is vulnerable.
PoC;
payload: </textarea><img src=x onerror=alert('xss_by_@om3rcitak')>
http://localhost/phppgadmin/display.php?subject=table&return=table&table=users&server=localhost:5432:allow&database=omer&schema=</textarea><img src=x onerror=alert('xss_by_@om3rcitak')>
OR
http://localhost/phppgadmin/display.php?subject=table&return=table&table=</textarea><img src=x onerror=alert('xss_by_@om3rcitak')>&server=localhost:5432:allow&database=omer&schema=public
Robert Treat [Sat, 20 Jul 2019 21:04:44 +0000 (17:04 -0400)]
Fix bug with partial SQL execution failure.
Fix based on patches from @nirgal and @LuckySB
Reported at:
https://sourceforge.net/p/phppgadmin/bugs/448/
https://bugs.debian.org/762378
https://github.com/phppgadmin/phppgadmin/pull/27
https://github.com/phppgadmin/phppgadmin/pull/30
Jean-Michel Nirgal Vourgère [Tue, 7 Apr 2015 17:45:56 +0000 (19:45 +0200)]
Change perms exec bit
chmod -x all php files without a #!
chmod +x those with one.
Robert Treat [Fri, 19 Jul 2019 20:40:03 +0000 (16:40 -0400)]
PG11 changes pg_proc.proisagg to prokind to support stored procedures and
window functions, breaking functions, aggregates, and object look-up within
PPA. This commit fixes all three of these areas. In theory we should probably
add some display bits to help users differentiate between these different
types in the UI, but this at least makes the system work again.
Thanks to @decodeJarvis who initially reported the problem and provided a
proposed fix (see PR#24 on the xzilla repo). Since we needed a more
comprehensive fix, I didn't use the code, but his patch was useful for getting
started.
Marcelo Pires de Almeida [Sun, 21 Apr 2019 19:54:53 +0000 (16:54 -0300)]
Adjusted bootstrap 3.3.7 and CSS
Sjon Hortensius [Wed, 17 Jul 2019 08:22:20 +0000 (10:22 +0200)]
php-7.2 fix - 'each' has been deprecated
Robert Treat [Tue, 16 Jul 2019 22:34:50 +0000 (18:34 -0400)]
Clean up DEVELOPERS file and overhaul instructions for using feature branches
Robert Treat [Sat, 13 Jul 2019 16:24:30 +0000 (12:24 -0400)]
Fix pass by reference warnings in index creation.
Robert Treat [Sun, 7 Jul 2019 00:08:13 +0000 (20:08 -0400)]
Merge pull request #59 from xzilla/fix_gui_warning
Fix deprecation warning with printCombo
Robert Treat [Sat, 6 Jul 2019 23:50:02 +0000 (19:50 -0400)]
Fix Deprecation Warning: Non-static method GUI::printCombo() should not be called statically
Robert Treat [Sat, 6 Jul 2019 23:07:19 +0000 (19:07 -0400)]
Merge pull request #25 from phppgadmin/master
sync upstream back to dev repo
Robert Treat [Sat, 6 Jul 2019 23:03:44 +0000 (19:03 -0400)]
resolve conflicts for pr #25 sync upstream back to dev repo
Robert Treat [Fri, 28 Jun 2019 03:53:19 +0000 (23:53 -0400)]
At last, the long awaited patch for php7 support.
This commit is focused strictly on the class/constructor changes. This has
primarily been tested on php 7.1 and postgres 11, with all tests passing though
there are some spurious warnings; I have fixes for them but will add them in
seperate commits.
Note that the code here is my own, but I did look at patches from
@gabrielhomsi and @w1ldzer0 for some sanity checking. Any bugs or missing
items are on me.
Robert Treat [Tue, 13 Nov 2018 17:23:07 +0000 (12:23 -0500)]
mark PPA version 7.x-dev
Robert Treat [Mon, 12 Nov 2018 23:44:42 +0000 (18:44 -0500)]
Mark PPA release 5.6
Robert Treat [Mon, 12 Nov 2018 23:06:28 +0000 (18:06 -0500)]
Review/Update BUGS CREDITS HISTORY and TODO before release
firzen [Thu, 1 Nov 2018 06:12:17 +0000 (14:12 +0800)]
Translate Vacuum of Chinese fixed
Augusto Teixeira da Costa [Thu, 1 Dec 2016 16:25:10 +0000 (14:25 -0200)]
Fixed Error Line 686
Error: Divid By Zero
Robert Treat [Mon, 12 Nov 2018 20:52:27 +0000 (15:52 -0500)]
Merge pull request #17 from multidadosti-erp/master
Fixed Error Line 686
Laurens Ramandt [Wed, 28 Sep 2016 13:01:18 +0000 (15:01 +0200)]
Dutch.php: spelling mistake
step1stepn [Mon, 22 May 2017 22:28:38 +0000 (01:28 +0300)]
Bug fix in native word of Ukrainian
Changed ukrainian symbols in localization file
Correct ukrainian symbols in UTF-8 encoding
Robert Treat [Thu, 1 Nov 2018 22:25:33 +0000 (17:25 -0500)]
Fix links for help docs on new versions. Really we should refactor this like with the database classes, but just extending it for now.
Robert Treat [Thu, 1 Nov 2018 22:16:57 +0000 (17:16 -0500)]
Fix links for help docs on new versions. Really we should refactor this like with the database classes, but just extending it for now.
Robert Treat [Tue, 30 Oct 2018 21:40:56 +0000 (16:40 -0500)]
Merge pull request #22 from webmasterMeyers/patch-1
Update global.css
Chad Meyers [Thu, 18 Oct 2018 17:39:59 +0000 (14:39 -0300)]
Update global.css
fix css (logo background picture)
Robert Treat [Sat, 27 Oct 2018 14:12:54 +0000 (10:12 -0400)]
grammer / typo fixes in developer file
Robert Treat [Sat, 27 Oct 2018 14:03:27 +0000 (10:03 -0400)]
Add support for Postgres 9.6, 10, 11, and 12. Verify tests passing
Robert Treat [Sat, 27 Oct 2018 13:58:25 +0000 (09:58 -0400)]
Add support for Postgres 9.6, 10, 11, and 12. Verify tests passing on all supported versions.
Robert Treat [Fri, 26 Oct 2018 19:10:40 +0000 (15:10 -0400)]
Add support for Postgres 9.6, 10, 11, and 12. Verify tests passing on all supported versions.
Chad Meyers [Thu, 18 Oct 2018 17:39:59 +0000 (14:39 -0300)]
Update global.css
fix css (logo background picture)
Robert Treat [Mon, 30 Oct 2017 22:41:04 +0000 (18:41 -0400)]
grammer / typo fixes in developer file
Robert Treat [Mon, 30 Oct 2017 22:41:04 +0000 (18:41 -0400)]
grammer / typo fixes in developer file
Massimiliano Arione [Mon, 11 Apr 2016 13:52:46 +0000 (15:52 +0200)]
Remove "-i" flag from pg_dump
With Postgres 9.5 (that is default on new Ubuntu LTS, so likely to spread soon) the `-i` option is causing an error, since it has been removed.
Anyway, such option has been deprecated since Postgres 8.4 (so about 6 years ago)
John K. Harvey [Mon, 29 Feb 2016 17:39:50 +0000 (12:39 -0500)]
Explicit Support for PG 9.5
Miguel Angel Useche Castro [Thu, 14 Apr 2016 00:58:48 +0000 (20:28 -0430)]
Fixing spanish typo
Robert Treat [Thu, 5 Mar 2015 04:35:00 +0000 (20:35 -0800)]
Fix SF Bug #446 pagination not changing page (through select).
Fix by timding and ronlm
Robert Treat [Mon, 16 Feb 2015 03:02:15 +0000 (22:02 -0500)]
Fix help links for pg 9.3 / 9.4
Robert Treat [Mon, 16 Feb 2015 00:55:25 +0000 (19:55 -0500)]
Update History and Credits based on recent patches
Robert Treat [Mon, 16 Feb 2015 00:48:01 +0000 (19:48 -0500)]
clean up some developer suggestions
firzen [Sun, 30 Mar 2014 02:54:13 +0000 (10:54 +0800)]
improve data management navigation; adds browse/search options to tables/views, and insert to tables. Based on patch by firzen, with additional work by xzilla
Robert Treat [Sun, 15 Feb 2015 17:02:22 +0000 (12:02 -0500)]
htmlescape column comments. per suggestion from github user nboutelier
Jehan-Guillaume [Thu, 12 Feb 2015 11:38:57 +0000 (12:38 +0100)]
Add file upload capability to SQL popup window
This feature was accessible only from the main SQL page, but not from
the popup when upsing the top SQL link.
Felipe Figueroa [Tue, 30 Sep 2014 15:56:52 +0000 (12:56 -0300)]
Bootstrap theme
Robert Treat [Sat, 7 Feb 2015 20:52:44 +0000 (15:52 -0500)]
Enable querying over inspected tables / views. This was based on a patch by Felipe Figueroa <amenadiel@gmail.com>
resolves #22
Robert Treat [Sun, 1 Feb 2015 19:38:01 +0000 (14:38 -0500)]
Explicit Support for PG 9.4
Robert Treat [Sun, 1 Feb 2015 19:31:07 +0000 (14:31 -0500)]
Make json and jsonb data types display as textarea rather than 1 line input fields. Inspired by patch from Felipe Figueroa <amenadiel@gmail.com>
Robert Treat [Sun, 25 Jan 2015 16:33:54 +0000 (11:33 -0500)]
Admin processes test didnt seem to know about 'blocked' column. It does now. How did that ever work?
Robert Treat [Sun, 25 Jan 2015 15:35:44 +0000 (10:35 -0500)]
Add a starter 5.2 Section to the HISTORY file
Christopher Harrington [Mon, 24 Nov 2014 07:30:40 +0000 (01:30 -0600)]
Add line item to "TODO" about Materialized Views
dMagsCan [Wed, 7 Jan 2015 12:03:08 +0000 (14:03 +0200)]
Update turkish.php
The empty line end of the file causing to fail ajax response that containts xml header
Miguel Angel Useche Castro [Wed, 24 Dec 2014 22:04:58 +0000 (17:34 -0430)]
Better spanish translation file
Jehan-Guillaume [Mon, 8 Sep 2014 16:10:12 +0000 (18:10 +0200)]
Fix javascript bug with popups
Dynamic themes applies the current main frame theme to the browser
tree frame without checking if it actually exists in the current
window.
Thispatch fix the resulting javascript error, breaking any other
following code.
Robert Treat [Sun, 20 Jul 2014 23:43:03 +0000 (19:43 -0400)]
make blank msg lines consistent
Jehan-Guillaume [Thu, 17 Apr 2014 17:48:22 +0000 (19:48 +0200)]
Fix bug #444
https://sourceforge.net/p/phppgadmin/bugs/444/
Szabolcs Hubai [Tue, 4 Mar 2014 21:42:46 +0000 (22:42 +0100)]
Convert spaces back to tabs introduced in
8ebf7562291f for email readability.
Hidde Boomsma [Mon, 13 May 2013 07:02:38 +0000 (09:02 +0200)]
set required php version to 5.0
Hidde Boomsma [Mon, 22 Apr 2013 14:20:14 +0000 (16:20 +0200)]
added composer support
Robert Treat [Sun, 2 Mar 2014 06:08:01 +0000 (01:08 -0500)]
minor cleanup; be consistent in lowercasing PHP keywords
Robert Treat [Sun, 2 Mar 2014 05:48:05 +0000 (00:48 -0500)]
This is a horrible commit, but it cleans up hundreds of warnings that get thrown when a class is not specified, and it fixes it so that the broken admin tests pass. I'm pretty sure that ultimately we will want a better fix than this, but I'm taking the progress when I can get it. AFAICT the affore mentioned problems were introduced in https://github.com/phppgadmin/phppgadmin/commit/
4680728829d8f95e29514512c9e94bb5345aa58a. If that was something you wanted, it's quite possibly broken now.
Augusto Teixeira da Costa [Thu, 1 Dec 2016 16:25:10 +0000 (14:25 -0200)]
Fixed Error Line 686
Error: Divid By Zero
Massimiliano Arione [Mon, 11 Apr 2016 13:52:46 +0000 (15:52 +0200)]
Remove "-i" flag from pg_dump
With Postgres 9.5 (that is default on new Ubuntu LTS, so likely to spread soon) the `-i` option is causing an error, since it has been removed.
Anyway, such option has been deprecated since Postgres 8.4 (so about 6 years ago)