projects / postgresql.git / commitdiff
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: e3c0d67)
Fix contrib/pgstattuple and contrib/pageinspect to prevent attempts to read
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 31 Mar 2009 22:56:28 +0000 (22:56 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 31 Mar 2009 22:56:28 +0000 (22:56 +0000)
temporary tables of other sessions; that is unsafe because of the way our
buffer management works.  Per report from Stuart Bishop.
This is redundant with the bufmgr.c checks in HEAD, but not at all redundant
in the back branches.

contrib/pgstattuple/pgstattuple.c patch | blob | blame | history

diff --git a/contrib/pgstattuple/pgstattuple.c b/contrib/pgstattuple/pgstattuple.c
index 31de26aa3feb6f564c19c914796b026aa302113f..bac41ceabc53c7514dd2631a7f3aac207c6c4168 100644 (file)
--- a/contrib/pgstattuple/pgstattuple.c
+++ b/contrib/pgstattuple/pgstattuple.c
@@ -1,5 +1,5 @@
 /*
- * $Header: /cvsroot/pgsql/contrib/pgstattuple/pgstattuple.c,v 1.12.4.1 2004/10/13 22:22:00 tgl Exp $
+ * $Header: /cvsroot/pgsql/contrib/pgstattuple/pgstattuple.c,v 1.12.4.2 2009/03/31 22:56:28 tgl Exp $
  *
  * Copyright (c) 2001,2002 Tatsuo Ishii
  *
@@ -117,6 +117,16 @@ pgstattuple_real(Relation rel)
    int         i;
    Datum       result;
 
+   /*
+    * Reject attempts to read non-local temporary relations; we would
+    * be likely to get wrong data since we have no visibility into the
+    * owning session's local buffers.
+    */
+   if (isOtherTempNamespace(RelationGetNamespace(rel)))
+       ereport(ERROR,
+               (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+                errmsg("cannot access temporary tables of other sessions")));
+
    /*
     * Build a tuple description for a pgstattupe_type tuple
     */
This is the main PostgreSQL git repository.