projects / postgresql.git / commitdiff
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 991407a)
Add missing string terminator
authorDaniel Gustafsson <dgustafsson@postgresql.org>
Wed, 30 Apr 2025 08:34:08 +0000 (10:34 +0200)
committerDaniel Gustafsson <dgustafsson@postgresql.org>
Wed, 30 Apr 2025 08:34:08 +0000 (10:34 +0200)
When copying the string strncpy won't add nul termination since
the string length is equal to the length specified.  Explicitly
set a nul terminator after copying to properly terminate. Found
via post-commit review.

Author: Rahila Syed <rahilasyed90@gmail.com>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://postgr.es/m/CAH2L28vt16C9xTuK+K7QZvtA3kCNWXOEiT=gEekUw3Xxp9LVQw@mail.gmail.com

src/backend/utils/mmgr/mcxt.c patch | blob | blame | history

diff --git a/src/backend/utils/mmgr/mcxt.c b/src/backend/utils/mmgr/mcxt.c
index 506f29029865c0590e02ff15b07f6f921826fae6..786e92039b1b3c3a3886fb46c9f9703cd7328a74 100644 (file)
--- a/src/backend/utils/mmgr/mcxt.c
+++ b/src/backend/utils/mmgr/mcxt.c
@@ -1663,6 +1663,7 @@ ProcessGetMemoryContextInterrupt(void)
            meminfo[max_stats - 1].name = dsa_allocate(MemoryStatsDsaArea, namelen + 1);
            nameptr = dsa_get_address(MemoryStatsDsaArea, meminfo[max_stats - 1].name);
            strncpy(nameptr, "Remaining Totals", namelen);
+           nameptr[namelen] = '\0';
            meminfo[max_stats - 1].ident = InvalidDsaPointer;
            meminfo[max_stats - 1].path = InvalidDsaPointer;
            meminfo[max_stats - 1].type = 0;
This is the main PostgreSQL git repository.