projects / postgresql.git / commitdiff
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 5773fac)
Fix PL/Python memory leak involving array slices
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 17 Mar 2011 15:49:38 +0000 (12:49 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 17 Mar 2011 15:50:38 +0000 (12:50 -0300)
Report and patch from Daniel Popowich, bug #5842
(with some debugging help from Alex Hunsaker)

src/pl/plpython/plpython.c patch | blob | blame | history

diff --git a/src/pl/plpython/plpython.c b/src/pl/plpython/plpython.c
index edcbc2a7ed89a42af6be88ae2e52f0bbe828f924..f89071ec73464be332cbbc3fd17f600a12c13d67 100644 (file)
--- a/src/pl/plpython/plpython.c
+++ b/src/pl/plpython/plpython.c
@@ -2261,14 +2261,9 @@ PLy_result_ass_item(PyObject * arg, Py_ssize_t idx, PyObject * item)
 static PyObject *
 PLy_result_slice(PyObject * arg, Py_ssize_t lidx, Py_ssize_t hidx)
 {
-   PyObject   *rv;
    PLyResultObject *ob = (PLyResultObject *) arg;
 
-   rv = PyList_GetSlice(ob->rows, lidx, hidx);
-   if (rv == NULL)
-       return NULL;
-   Py_INCREF(rv);
-   return rv;
+   return PyList_GetSlice(ob->rows, lidx, hidx);
 }
 
 static int
This is the main PostgreSQL git repository.